mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: Jiri Kosina <jkosina@suse.cz>
Cc: hannes@cmpxchg.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: how to properly post/disseminate kernel cleanup/janitorial possibilities?
Date: Wed, 29 Apr 2009 09:44:53 -0400 (EDT)	[thread overview]
Message-ID: <alpine.LFD.2.00.0904290938310.5304@localhost.localdomain> (raw)
In-Reply-To: <alpine.LNX.2.00.0904291400200.5012@wotan.suse.de>

On Wed, 29 Apr 2009, Jiri Kosina wrote:

> On Tue, 28 Apr 2009, Robert P. J. Day wrote:
>
> > > > Perhaps Jiri can pick up some of the patches that remove stale
> > > > config symbols, correct typos etc.

> > > Absolutely. I'll happily apply anything trivial enough (typo fixes,
> > > removal of obviously unused symbols/config options, etc).

> > the *problem* is that, sometimes, it's not obvious.  as in, when a
> > Kconfig file has a pile of unused config options but it turns out
> > that those were added for future consideration to match up with
> > code that hasn't been added yet and the subsystem maintainer knows
> > about it but wants it to stay (IMHO, a really bad idea -- adding
> > kernel features in incomplete pieces, but whatever).
>
> Hmm ... do you have any particular outstanding examples of this?

  historically, plenty, based on the number of times i've submitted
patches to various maintainers to remove unused symbols, only to be
told that those symbols were added in a preliminary fashion, and the
accompanying code should be along any day now.  obviously, that
doesn't cause any actual problems but it certainly messes up the
history of a feature by breaking its introduction over more than one
patch.

  and as for *current* examples, well, there's this page:

http://www.crashcourse.ca/wiki/index.php/Unused_CONFIG_variables

one recent example was MAC80211_VERBOSE_SPECT_MGMT_DEBUG, if you
wanted an actual reference.

  really, i'm *aware* that 99% of this scanning and cleanup is benign.
but that final 1% sometimes really does represent a bug and, since i
have the scripts and it's pretty much free to run them whenever i
want, we're back to the original question -- what's the best venue to
distribute this info so as not to bore to tears the people who don't
care about it?

rday
--

========================================================================
Robert P. J. Day                               Waterloo, Ontario, CANADA

        Linux Consulting, Training and Annoying Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Linked In:                             http://www.linkedin.com/in/rpjday
Twitter:                                       http://twitter.com/rpjday
========================================================================

      reply	other threads:[~2009-04-29 13:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-27 20:46 Robert P. J. Day
2009-04-27 21:05 ` Bill Gatliff
2009-04-27 22:20 ` Johannes Weiner
2009-04-28  8:25   ` Jiri Kosina
2009-04-28 10:31     ` Robert P. J. Day
2009-04-29 12:01       ` Jiri Kosina
2009-04-29 13:44         ` Robert P. J. Day [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.0904290938310.5304@localhost.localdomain \
    --to=rpjday@crashcourse.ca \
    --cc=hannes@cmpxchg.org \
    --cc=jkosina@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®