From: Thomas Gleixner <tglx@linutronix.de>
To: Jaswinder Singh Rajput <jaswinder@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, Al Viro <viro@zeniv.linux.org.uk>,
x86 maintainers <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC][PATCH -tip] x86: audit.c remove unnecessary global arraysn
Date: Wed, 13 May 2009 21:42:51 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.00.0905132136300.3561@localhost.localdomain> (raw)
In-Reply-To: <1242240694.3364.3.camel@localhost.localdomain>
On Thu, 14 May 2009, Jaswinder Singh Rajput wrote:
> ia32_dir_class[], ia32_write_class[], ia32_read_class[], ia32_chattr_class[]
> and ia32_signal_class[] are used only by arch/x86/kernel/audit_64.c
> which can be replace by local variables:
>
> dir_class[], write_class[], read_class[], chattr_class[] and signal_class[]
Groan, it can be replaced by local variables, but it does not result
in the same functionality.
These audit classes are arrays of syscall numbers, which are different
for 32 and 64 bit. ia32/audit.c includes unistd_32.h not unistd.h for
exactly this reason.
Thanks,
tglx
next prev parent reply other threads:[~2009-05-13 19:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-13 18:51 [RFC][PATCH -tip] x86: audit.c remove unnecessary global arrays Jaswinder Singh Rajput
2009-05-13 19:42 ` Thomas Gleixner [this message]
2009-05-13 19:49 ` [RFC][PATCH -tip] x86: audit.c remove unnecessary global arraysn Jaswinder Singh Rajput
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0905132136300.3561@localhost.localdomain \
--to=tglx@linutronix.de \
--cc=jaswinder@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=viro@zeniv.linux.org.uk \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®