From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761269AbZENHzL (ORCPT ); Thu, 14 May 2009 03:55:11 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759528AbZENHy5 (ORCPT ); Thu, 14 May 2009 03:54:57 -0400 Received: from www.tglx.de ([62.245.132.106]:49507 "EHLO www.tglx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756857AbZENHy4 (ORCPT ); Thu, 14 May 2009 03:54:56 -0400 Date: Thu, 14 May 2009 09:53:44 +0200 (CEST) From: Thomas Gleixner To: Jaswinder Singh Rajput cc: Ingo Molnar , x86 maintainers , LKML Subject: Re: [PATCH 1/2] x86: apic/apic.c declare default_init_apic_ldr() before it get used In-Reply-To: <1242251841.3364.17.camel@localhost.localdomain> Message-ID: References: <1242251841.3364.17.camel@localhost.localdomain> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 14 May 2009, Jaswinder Singh Rajput wrote: > > default_init_apic_ldr() is also required for 64 bit so moving it out > from CONFIG_X86_32. [linux-2.6-tip]$ git grep default_init_apic_ldr arch/x86/ arch/x86/include/asm/apic.h:extern void default_init_apic_ldr(void); arch/x86/kernel/apic/apic.c:void default_init_apic_ldr(void) arch/x86/kernel/apic/probe_32.c: .init_apic_ldr = default_init_apic_ldr, I have a hard time to see how 64bit requires that function. Thanks, tglx