From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755847AbZEUNLZ (ORCPT ); Thu, 21 May 2009 09:11:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752833AbZEUNLS (ORCPT ); Thu, 21 May 2009 09:11:18 -0400 Received: from astoria.ccjclearline.com ([64.235.106.9]:41845 "EHLO astoria.ccjclearline.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752380AbZEUNLR (ORCPT ); Thu, 21 May 2009 09:11:17 -0400 Date: Thu, 21 May 2009 09:09:53 -0400 (EDT) From: "Robert P. J. Day" X-X-Sender: rpjday@localhost.localdomain To: Alexander Beregalov cc: gregkh@suse.de, linux-kernel@vger.kernel.org, linux-next@vger.kernel.org Subject: Re: [PATCH] Staging: comedi: comedidev should include delay.h In-Reply-To: <1242911193-30469-1-git-send-email-a.beregalov@gmail.com> Message-ID: References: <1242911193-30469-1-git-send-email-a.beregalov@gmail.com> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - astoria.ccjclearline.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - crashcourse.ca X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 21 May 2009, Alexander Beregalov wrote: > Fix many build errors like this: > comedi/drivers/adq12b.c:328: error: implicit declaration of function 'udelay' > > The same for aio_aio12_8.c, dmm32at.c and others. > > Signed-off-by: Alexander Beregalov > --- > drivers/staging/comedi/comedidev.h | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h > index 7a1ccde..3d0e80c 100644 > --- a/drivers/staging/comedi/comedidev.h > +++ b/drivers/staging/comedi/comedidev.h > @@ -38,6 +38,7 @@ > #include > #include > #include > +#include > > #include "comedi.h" not sure it's worth noting but the header comedidev.h currently resides in the comedi directory itself, while the source file rt.c contains: #include which doesn't seem right. and that local comedidev.h header file contains the comment: /* include/linux/comedidev.h as if it *were* really under include/linux. perhaps someone would like to clarify that. just an observation. rday -- ======================================================================== Robert P. J. Day Waterloo, Ontario, CANADA Linux Consulting, Training and Annoying Kernel Pedantry. Web page: http://crashcourse.ca Linked In: http://www.linkedin.com/in/rpjday Twitter: http://twitter.com/rpjday ========================================================================