mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Oleg Nesterov <oleg@redhat.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH resend4 3/3] itimers: simplify arm_timer() code a bit
Date: Fri, 22 May 2009 18:59:03 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LFD.2.00.0905221858350.3570@localhost.localdomain> (raw)
In-Reply-To: <20090522163625.1e1dd8ce@dhcp-lab-109.englab.brq.redhat.com>

On Fri, 22 May 2009, Stanislaw Gruszka wrote:
> On Fri, 22 May 2009 16:30:09 +0200 (CEST)
> Thomas Gleixner <tglx@linutronix.de> wrote:
> 
> > On Fri, 22 May 2009, Stanislaw Gruszka wrote:
> > >  			case CPUCLOCK_PROF:
> > > -				if (cputime_eq(p->cputime_expires.prof_exp,
> > > -					       cputime_zero) ||
> > > -				    cputime_gt(p->cputime_expires.prof_exp,
> > > -					       nt->expires.cpu))
> > > -					p->cputime_expires.prof_exp =
> > > -						nt->expires.cpu;
> > > +				if (expires_le(p->cputime_expires.prof_exp,
> > > +					       exp->cpu))
> > > +					break;
> > 
> >   Why the reverse logic and the extra break ?
> 
> Just to use helper and to make similar logic in all cases in this funcion.

Well, you can do that the other way round as well :)

Thanks,

	tglx

      reply	other threads:[~2009-05-22 17:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-22 13:43 Stanislaw Gruszka
2009-05-22 14:30 ` Thomas Gleixner
2009-05-22 14:36   ` Stanislaw Gruszka
2009-05-22 16:59     ` Thomas Gleixner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.0905221858350.3570@localhost.localdomain \
    --to=tglx@linutronix.de \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=oleg@redhat.com \
    --cc=sgruszka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®