mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Bart Oldeman <bartoldeman@users.sourceforge.net>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, stable@kernel.org
Subject: Re: [PATCH] x86, vm86: fix preemption bug for int3 breakpoint handlers.
Date: Mon, 25 May 2009 12:33:20 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LFD.2.00.0905251225190.3582@localhost.localdomain> (raw)
In-Reply-To: <alpine.DEB.2.00.0905241834110.17184@localhost.localdomain>

Bart,

On Sun, 24 May 2009, Bart Oldeman wrote:
> diff --git a/arch/x86/kernel/vm86_32.c b/arch/x86/kernel/vm86_32.c
> index b8035a0..17c7734 100644
> --- a/arch/x86/kernel/vm86_32.c
> +++ b/arch/x86/kernel/vm86_32.c
> @@ -551,8 +551,12 @@ cannot_handle:
>  int handle_vm86_trap(struct kernel_vm86_regs *regs, long error_code, int
> trapno)
>  {
>  	if (VMPI.is_vm86pus) {
> -		if ((trapno == 3) || (trapno == 1))
> +		if ((trapno == 3) || (trapno == 1)) {
> +			/* re-enable preemption: return_to_32bit()
> +			   jumps straight to entry_32.S */
> +			dec_preempt_count();

  This will break other callers of handle_vm86_trap().

Thanks,

	tglx



  reply	other threads:[~2009-05-25 10:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-24 22:35 Bart Oldeman
2009-05-25 10:33 ` Thomas Gleixner [this message]
2009-12-05 15:06   ` Bart Oldeman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.0905251225190.3582@localhost.localdomain \
    --to=tglx@linutronix.de \
    --cc=bartoldeman@users.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®