From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761188AbZE1OqU (ORCPT ); Thu, 28 May 2009 10:46:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755250AbZE1OqJ (ORCPT ); Thu, 28 May 2009 10:46:09 -0400 Received: from www.tglx.de ([62.245.132.106]:47126 "EHLO www.tglx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753421AbZE1OqJ (ORCPT ); Thu, 28 May 2009 10:46:09 -0400 Date: Thu, 28 May 2009 16:45:37 +0200 (CEST) From: Thomas Gleixner To: Steven Rostedt cc: wuzhangjin@gmail.com, linux-mips@linux-mips.org, LKML , Ralf Baechle , Ingo Molnar , Andrew Morton , Nicholas Mc Guire , wuzj@lemote.com Subject: Re: [PATCH] mips-specific ftrace support In-Reply-To: Message-ID: References: <73465d64a9a6773936f5eab3735a69f651c13187.1243458732.git.wuzj@lemote.com> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 28 May 2009, Steven Rostedt wrote: > On Thu, 28 May 2009, wuzhangjin@gmail.com wrote: > Could you possibly break this patch up into porting the tracers one by > one. That is: > > First patch: make function tracing work. > Second patch: make dynamic tracing work. > Third patch: add Function graph tracing. > Forth patch: the time stamp updates > > This would make things a lot easier to review, and if one of the changes > breaks something, it will be easier to bisect. > > include/linux/clocksource.h | 4 +- > > kernel/sched_clock.c | 2 +- > > kernel/trace/ring_buffer.c | 3 +- > > kernel/trace/trace_clock.c | 2 +- > > scripts/Makefile.build | 1 + > > scripts/recordmcount.pl | 31 +++- The changes to these generic files need to be separate as well. Thanks, tglx