From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
Russell King <rmk+lkml@arm.linux.org.uk>,
Ingo Molnar <mingo@elte.hu>
Subject: [PATCH] genirq: do not disable IRQ_WAKEUP marked irqs on suspend
Date: Fri, 12 Jun 2009 19:09:34 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.00.0906121906140.3369@localhost.localdomain> (raw)
commit 0a0c5168df (PM: Introduce functions for suspending and resuming
device interrupts) iterates through all interrupts and disables them
on the hardware level. Some architectures have functionality
implemented to mark an interrupt source as wakeup source for suspend,
but the new power management code disables them unconditionally which
breaks the resume on interrupt functionality.
The wakeup interrupts are marked in the status with the IRQ_WAKEUP
bit. Skip the disablement for those interrupts which have the
IRQ_WAKEUP bit set.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: stable@kernel.org
diff --git a/kernel/irq/pm.c b/kernel/irq/pm.c
index 638d8be..bce6afd 100644
--- a/kernel/irq/pm.c
+++ b/kernel/irq/pm.c
@@ -29,7 +29,8 @@ void suspend_device_irqs(void)
unsigned long flags;
spin_lock_irqsave(&desc->lock, flags);
- __disable_irq(desc, irq, true);
+ if (!(desc->status & IRQ_WAKEUP))
+ __disable_irq(desc, irq, true);
spin_unlock_irqrestore(&desc->lock, flags);
}
next reply other threads:[~2009-06-12 17:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-12 17:09 Thomas Gleixner [this message]
[not found] <cMiA9-1MZ-13@gated-at.bofh.it>
2009-06-12 17:56 ` Kevin Hilman
2009-06-12 18:09 ` Thomas Gleixner
2009-06-12 18:33 ` Kevin Hilman
2009-06-12 19:52 ` Thomas Gleixner
2009-06-22 21:27 ` Andrew Morton
2009-06-22 22:56 ` Rafael J. Wysocki
2009-06-22 22:54 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0906121906140.3369@localhost.localdomain \
--to=tglx@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rjw@sisk.pl \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®