mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: "mingo@elte.hu" <mingo@elte.hu>, "hpa@zytor.com" <hpa@zytor.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>,
	"Brown, Len" <len.brown@intel.com>
Subject: Re: [patch] clockevents_notify() need to be called with irq's enabled
Date: Mon, 17 Aug 2009 23:27:50 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LFD.2.00.0908172325380.2782@localhost.localdomain> (raw)
In-Reply-To: <1250544150.2709.197.camel@sbs-t61.sc.intel.com>

Suresh,

On Mon, 17 Aug 2009, Suresh Siddha wrote:

> --- tip.orig/arch/x86/kernel/process.c
> +++ tip/arch/x86/kernel/process.c
> @@ -508,17 +508,10 @@ static void c1e_idle(void)
>  
>  		if (!cpumask_test_cpu(cpu, c1e_mask)) {
>  			cpumask_set_cpu(cpu, c1e_mask);
> -			/*
> -			 * Force broadcast so ACPI can not interfere. Needs
> -			 * to run with interrupts enabled as it uses
> -			 * smp_function_call.
> -			 */

Please keep the first sentence of the comment intact. Everything else
looks fine.

Thanks,

	tglx


  reply	other threads:[~2009-08-17 21:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-13 22:48 Suresh Siddha
2009-08-14  6:05 ` Thomas Gleixner
2009-08-14  7:26   ` Suresh Siddha
2009-08-14  8:28     ` Thomas Gleixner
2009-08-14 17:39       ` Suresh Siddha
2009-08-14 20:01         ` Thomas Gleixner
2009-08-17 21:22           ` Suresh Siddha
2009-08-17 21:27             ` Thomas Gleixner [this message]
2009-08-17 21:34               ` Suresh Siddha
2009-08-19 16:18                 ` [tip:timers/urgent] clockevent: Prevent dead lock on clockevents_lock tip-bot for Suresh Siddha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.0908172325380.2782@localhost.localdomain \
    --to=tglx@linutronix.de \
    --cc=hpa@zytor.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=suresh.b.siddha@intel.com \
    --cc=venkatesh.pallipadi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®