From: Thomas Gleixner <tglx@linutronix.de>
To: Daniele Calore <orkaan@orkaan.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Peter Anvin <hpa@zytor.com>,
Arjan van de Veen <arjan@infradead.org>,
Pan Jacob jun <jacob.jun.pan@intel.com>
Subject: Re: [patch 2/3] x86/boot: adding hw subarch ID for Moorestown
Date: Mon, 31 Aug 2009 12:01:50 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.00.0908311121340.19335@localhost.localdomain> (raw)
In-Reply-To: <20090831131359.0cc90d4d@buddha>
On Mon, 31 Aug 2009, Daniele Calore wrote:
> I think there is a typo (copy/paste error), see below:
>
> > #endif /* _ASM_X86_BOOTPARAM_H */
> > Index: linux-2.6-tip/arch/x86/kernel/head_32.S
> > ===================================================================
> > --- linux-2.6-tip.orig/arch/x86/kernel/head_32.S
> > +++ linux-2.6-tip/arch/x86/kernel/head_32.S
> > @@ -157,6 +157,7 @@ subarch_entries:
> > .long default_entry /* normal x86/PC */
> > .long lguest_entry /* lguest hypervisor */
> > .long xen_entry /* Xen hypervisor */
> > + .long default_entry /* Moorestown MID */
>
> Typo: s/default_entry/mrst_entry
That's not a typo. :)
MRST will not go via an separate entry it uses the default one and we
evaluate the hardware_subarch id later in i386_start_kernel. That
change is just necessecary that a paravirt enabled kernel does not end
up in bad_subarch for the MRST id.
Thanks,
tglx
next prev parent reply other threads:[~2009-08-31 10:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-30 13:46 [patch 0/3] x86: Early platform detection based on boot param subarch id Thomas Gleixner
2009-08-30 13:46 ` [patch 1/3] x86: Add early platform detection Thomas Gleixner
2009-08-30 13:46 ` [patch 2/3] x86/boot: adding hw subarch ID for Moorestown Thomas Gleixner
2009-08-31 11:13 ` Daniele Calore
2009-08-31 10:01 ` Thomas Gleixner [this message]
2009-08-30 13:46 ` [patch 3/3] x86: Add Moorestown early detection Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0908311121340.19335@localhost.localdomain \
--to=tglx@linutronix.de \
--cc=arjan@infradead.org \
--cc=hpa@zytor.com \
--cc=jacob.jun.pan@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=orkaan@orkaan.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®