mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Kacur <jkacur@redhat.com>
To: linux-kernel@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>
Cc: Jonathan Corbet <corbet@lwn.net>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Christoph Hellwig <hch@infradead.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Vincent Sanders <vince@simtec.co.uk>, Ingo Molnar <mingo@elte.hu>
Subject: [PATCH] sound_core.c: Remove BKL from soundcore_open
Date: Sun, 11 Oct 2009 01:24:14 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LFD.2.00.0910110123510.4921@localhost.localdomain> (raw)

>From 030af455d4f54482130c8eccb47fe90aaba8808c Mon Sep 17 00:00:00 2001
From: John Kacur <jkacur@redhat.com>
Date: Sat, 10 Oct 2009 23:39:56 +0200
Subject: [PATCH] This code is already protected by spin_lock, and doesn't require the bkl

Signed-off-by: John Kacur <jkacur@redhat.com>
---
 sound/sound_core.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/sound/sound_core.c b/sound/sound_core.c
index 49c9981..03bb943 100644
--- a/sound/sound_core.c
+++ b/sound/sound_core.c
@@ -576,8 +576,6 @@ static int soundcore_open(struct inode *inode, struct file *file)
 	struct sound_unit *s;
 	const struct file_operations *new_fops = NULL;
 
-	lock_kernel ();
-
 	chain=unit&0x0F;
 	if(chain==4 || chain==5)	/* dsp/audio/dsp16 */
 	{
@@ -637,11 +635,9 @@ static int soundcore_open(struct inode *inode, struct file *file)
 			file->f_op = fops_get(old_fops);
 		}
 		fops_put(old_fops);
-		unlock_kernel();
 		return err;
 	}
 	spin_unlock(&sound_loader_lock);
-	unlock_kernel();
 	return -ENODEV;
 }
 
-- 
1.6.0.6


             reply	other threads:[~2009-10-10 23:25 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-10 23:24 John Kacur [this message]
2009-10-10 23:42 ` Alan Cox
2009-10-11  0:25   ` John Kacur
2009-10-11 11:33     ` Frederic Weisbecker
2009-10-11 12:41       ` John Kacur
2009-10-11 14:12         ` Oliver Neukum
2009-10-11 20:40           ` Frederic Weisbecker
2009-10-11 21:25         ` John Kacur
2009-10-12  6:05         ` Takashi Iwai
2009-10-12  8:37           ` John Kacur
2009-10-12 10:17             ` Takashi Iwai
2009-10-12 10:42               ` John Kacur
2009-10-11 15:20     ` Jonathan Corbet
2009-10-11 17:15       ` Jonathan Corbet
2009-10-11 17:37         ` Arjan van de Ven
2009-10-11 19:17           ` Alan Cox
2009-10-11 19:26             ` Arjan van de Ven
2009-10-11 20:51               ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.0910110123510.4921@localhost.localdomain \
    --to=jkacur@redhat.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=corbet@lwn.net \
    --cc=fweisbec@gmail.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=vince@simtec.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®