mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
	Valdis.Kletnieks@vt.edu,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
	Heiko Carstens <heiko.carstens@de.ibm.com>
Subject: Re: 2.6.32-rc5-mmotm1101 - lockdep whinge during early boot
Date: Thu, 5 Nov 2009 15:54:48 +0100 (CET)	[thread overview]
Message-ID: <alpine.LFD.2.00.0911051547110.12138@localhost.localdomain> (raw)
In-Reply-To: <20091105141055.GA17350@redhat.com>

On Thu, 5 Nov 2009, Oleg Nesterov wrote:
> > Oleg (CC'd) made workqueues use cpu_maps_update_begin() instead of the
> > more obvious get_online_cpus() in 3da1c84c00c7e5f.  Reverting that seems like
> > a bad idea.
> 
> Even if create_workueue() used get_online_cpus() instead of cpu_add_remove_lock,
> we have the same problem: _cpu_up() takes cpu_hotplug.lock which is needed for
> get_online_cpus(). The dependency above becomes:
> 
> 	cpu_up()->clocksource_change_rating() takes clocksource_mutex under
> 	cpu_hotplug.lock (cpu_hotplug_begin)
> 
> 	clocksource_done_booting()->create_workueue() takes cpu_hotplug.lock
> 	(get_online_cpus) under clocksource_mutex

Hmm, we fixed all this lock madness in mainline already.
clocksource_done_booting() does not longer call
create_workqueue(). How got this code reverted in motm ?

Thanks,

	tglx

  parent reply	other threads:[~2009-11-05 14:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-04 16:11 Valdis.Kletnieks
2009-11-05  9:11 ` Rusty Russell
2009-11-05 14:10   ` Oleg Nesterov
2009-11-05 14:54     ` Martin Schwidefsky
2009-11-05 14:54     ` Thomas Gleixner [this message]
2009-11-05 15:22       ` Oleg Nesterov
2009-11-05 15:33         ` Oleg Nesterov
2009-11-05 15:54           ` Thomas Gleixner
2009-11-05 16:20             ` Martin Schwidefsky
2009-11-05 16:53               ` Thomas Gleixner
2009-11-09  9:43                 ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.0911051547110.12138@localhost.localdomain \
    --to=tglx@linutronix.de \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=akpm@linux-foundation.org \
    --cc=heiko.carstens@de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=oleg@redhat.com \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®