From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754744AbZKHR2F (ORCPT ); Sun, 8 Nov 2009 12:28:05 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754486AbZKHR2E (ORCPT ); Sun, 8 Nov 2009 12:28:04 -0500 Received: from eddie.linux-mips.org ([78.24.191.182]:58960 "EHLO eddie.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753552AbZKHR2D (ORCPT ); Sun, 8 Nov 2009 12:28:03 -0500 Date: Sun, 8 Nov 2009 17:28:05 +0000 (GMT) From: "Maciej W. Rozycki" To: Cyrill Gorcunov cc: Ingo Molnar , Yinghai Lu , x86team , LKML Subject: Re: [PATCH -tip] x86,apic: Use PAGE_SIZE instead of numbers In-Reply-To: <20091108155356.GB25940@lenovo> Message-ID: References: <20091108155356.GB25940@lenovo> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 8 Nov 2009, Cyrill Gorcunov wrote: > The whole page is reserved for IO-APIC fixmap > due to non-cacheable requirement. So lets note > this explicitly instead of playing with numbers. > > CC: Yinghai Lu > CC: "Maciej W. Rozycki" > Signed-off-by: Cyrill Gorcunov > --- Acked-by: Maciej W. Rozycki Is PAGE_SIZE still always 4kB for the x86 these days? If so, then your change makes sense to me. Maciej