From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755193AbZLBRGJ (ORCPT ); Wed, 2 Dec 2009 12:06:09 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755183AbZLBRGJ (ORCPT ); Wed, 2 Dec 2009 12:06:09 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:58086 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755132AbZLBRGI (ORCPT ); Wed, 2 Dec 2009 12:06:08 -0500 Date: Wed, 2 Dec 2009 09:05:00 -0800 (PST) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Jan Beulich cc: a.p.zijlstra@chello.nl, mingo@elte.hu, tglx@linutronix.de, mingo@redhat.com, npiggin@suse.de, linux-kernel@vger.kernel.org, hpa@zytor.com Subject: Re: [tip:core/locking] locking, x86: Slightly shorten __ticket_spin_trylock() In-Reply-To: Message-ID: References: <4B0FF9AC0200007800022713@vpn.id2.novell.com> <4B16A2CC020000780002313A@vpn.id2.novell.com> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2 Dec 2009, Linus Torvalds wrote: > > So stop making excuses. Just admit that 'bool' was wrong, and you made a > fundamental mistake in choosing it. The fact is, the compiler can do > whatever the hell it does, which is not necessarily sensible with any > other type. 'bool' really is special. Btw, even if gcc just treats 'bool' as 'char' (which is the sane thing to do on x86 anyway - I don't see why it should ever do anything else), we actually mess up in the kernel and make that type confusion even worse. Do this: git grep typedef.*bool and then do this: git grep 'define bool' and then sit down and cry silently. Linus