From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: x86@kernel.org, Cyrill Gorcunov <gorcunov@openvz.org>
Subject: [PATCH] x86: Fix bogus warning in apic_noop.apic_write()
Date: Mon, 7 Dec 2009 12:59:46 +0100 (CET) [thread overview]
Message-ID: <alpine.LFD.2.00.0912071255420.3089@localhost.localdomain> (raw)
apic_noop is used to provide dummy apic functions. It's installed when
the CPU has no APIC or when the APIC is disabled on the kernel command
line.
The apic_noop implementation of apic_write() warns when the CPU has an
APIC or when the APIC is not disabled.
That's bogus. The warning should only happen when the CPU has an APIC
_AND_ the APIC is not disabled. apic_noop.apic_read() has the correct
check.
[ @stable: in <= .32 this typo resides in native_apic_write_dummy(). ]
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: stable@kernel.org
---
arch/x86/kernel/apic/apic_noop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6/arch/x86/kernel/apic/apic_noop.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/apic/apic_noop.c
+++ linux-2.6/arch/x86/kernel/apic/apic_noop.c
@@ -127,7 +127,7 @@ static u32 noop_apic_read(u32 reg)
static void noop_apic_write(u32 reg, u32 v)
{
- WARN_ON_ONCE((cpu_has_apic || !disable_apic));
+ WARN_ON_ONCE((cpu_has_apic && !disable_apic));
}
struct apic apic_noop = {
next reply other threads:[~2009-12-07 12:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-07 11:59 Thomas Gleixner [this message]
2009-12-07 12:18 ` [tip:x86/urgent] " tip-bot for Thomas Gleixner
2009-12-07 15:04 ` Cyrill Gorcunov
2009-12-07 15:48 ` Thomas Gleixner
2009-12-07 16:30 ` Cyrill Gorcunov
2009-12-07 16:55 ` Thomas Gleixner
2009-12-07 18:04 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0912071255420.3089@localhost.localdomain \
--to=tglx@linutronix.de \
--cc=gorcunov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®