From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"David Miller" <davem@davemloft.net>,
xiyou.wangcong@gmail.com, x86@kernel.org,
linux-kernel@vger.kernel.org, tglx@linutronix.de,
mingo@redhat.com
Subject: Re: [PATCH] irq: handle irq0 special only on x86
Date: Sun, 13 Dec 2009 00:34:54 +0000 (GMT) [thread overview]
Message-ID: <alpine.LFD.2.00.0912130022090.14955@eddie.linux-mips.org> (raw)
In-Reply-To: <4B21246B.4070804@zytor.com>
On Thu, 10 Dec 2009, H. Peter Anvin wrote:
> > Note, I fully agree to use 0 for NO_IRQ if you have an int-sized value
> > that holds either NO_IRQ or a valid irq number. But in practise I'd not
> > recommend to use this idiom.
> >
>
> You're tilting at windmills about something that was settled long ago,
> like it or not.
This is nothing that couldn't be changed; my personal preference would be
quite the obvious choice of something along the lines of:
#define NO_IRQ -1U
that would also have the benefit of forcing all the relevant places to use
the macro rather than an expression like !irq, improving code readability
and greppability.
My motivation to push any such change at the moment is rather weak though
-- it's been a while since I was last pissed off by the weirdness of
assumptions about IRQ 0 in Linux.
Maciej
next prev parent reply other threads:[~2009-12-13 1:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-09 9:20 Uwe Kleine-König
2009-12-09 9:28 ` Américo Wang
2009-12-09 9:35 ` Uwe Kleine-König
2009-12-09 9:41 ` David Miller
2009-12-10 8:24 ` Uwe Kleine-König
2009-12-10 16:40 ` H. Peter Anvin
2009-12-13 0:34 ` Maciej W. Rozycki [this message]
2009-12-16 14:04 ` Uwe Kleine-König
2010-01-12 15:59 ` Uwe Kleine-König
2010-01-13 4:59 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0912130022090.14955@eddie.linux-mips.org \
--to=macro@linux-mips.org \
--cc=davem@davemloft.net \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
--cc=x86@kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome