mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Jonathan Corbet <corbet@lwn.net>
Cc: Keith Mannthey <kmannth@us.ibm.com>,
	lkml <linux-kernel@vger.kernel.org>,
	John Stultz <johnstul@us.ibm.com>
Subject: Re: [RFC][Patch] IBM Real-Time "SMI Free" mode drive -v2
Date: Wed, 16 Dec 2009 01:09:03 +0100 (CET)	[thread overview]
Message-ID: <alpine.LFD.2.00.0912160105510.2755@localhost.localdomain> (raw)
In-Reply-To: <20091215164950.1fd41caf@bike.lwn.net>

On Tue, 15 Dec 2009, Jonathan Corbet wrote:
> On Tue, 15 Dec 2009 12:09:48 -0800
> Keith Mannthey <kmannth@us.ibm.com> wrote:
>
> > +#include <linux/sysdev.h>
> > +#include <asm/byteorder.h>
> > +#include "rtl.h"
> > +
> > +static spinlock_t rtl_lock;
> 
> You should probably include <linux/spinlock.h> for this.

And use:

DEFINE_SPINLOCK(rtl_lock);

because the lock is uninitialized otherwise. Running that code with
lockdep would have warned about that.

Thanks,

	tglx

  reply	other threads:[~2009-12-16  0:09 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-15 20:09 Keith Mannthey
2009-12-15 23:12 ` Randy Dunlap
2009-12-15 23:58   ` Keith Mannthey
2009-12-15 23:49 ` Jonathan Corbet
2009-12-16  0:09   ` Thomas Gleixner [this message]
2009-12-16  0:38   ` Keith Mannthey
2009-12-16  0:50     ` Jonathan Corbet
2009-12-16  0:02 ` Alan Cox
2009-12-17  2:09   ` Keith Mannthey
2009-12-16 23:09 ` Peter Zijlstra
2009-12-17  1:37   ` john stultz
2009-12-17  2:06     ` Keith Mannthey
2009-12-17  1:50   ` Keith Mannthey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.0912160105510.2755@localhost.localdomain \
    --to=tglx@linutronix.de \
    --cc=corbet@lwn.net \
    --cc=johnstul@us.ibm.com \
    --cc=kmannth@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®