From: Linus Torvalds <torvalds@linux-foundation.org>
To: David Howells <dhowells@redhat.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
uclinux-dev@uclinux.org,
Daisuke HATAYAMA <d.hatayama@jp.fujitsu.com>,
Paul Mundt <lethal@linux-sh.org>
Subject: Re: [PATCH 4/4] elf_fdpic_core_dump(): fix build break in 2.6.33-rc1
Date: Wed, 6 Jan 2010 10:45:20 -0800 (PST) [thread overview]
Message-ID: <alpine.LFD.2.00.1001061044000.3630@localhost.localdomain> (raw)
In-Reply-To: <20100106172333.25862.40963.stgit@warthog.procyon.org.uk>
On Wed, 6 Jan 2010, David Howells wrote:
>
> From: Daisuke HATAYAMA <d.hatayama@jp.fujitsu.com>
>
> Commit f6151dfea21496d43dbaba32cfcd9c9f404769bc causes ELF-FDPIC to break
> during building, so this patch fixes it together with a correction for the
> printk format.
The comment doesn't match the patch. There's no build breakage fix (the
actual fix was already merged, and your patch reflects that), there's only
a printk format "fix" that is actually a de-provement because it splits
the string across multiple lines.
So a strong NAK to this patch.
Linus
next prev parent reply other threads:[~2010-01-06 18:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-06 17:23 [PATCH 1/4] FDPIC: Respect PT_GNU_STACK exec protection markings when creating NOMMU stack David Howells
2010-01-06 17:23 ` [PATCH 2/4] NOMMU: Avoiding duplicate icache flushes of shared maps David Howells
2010-01-06 17:23 ` [PATCH 3/4] NOMMU: Use copy_*_user_page() in access_process_vm() David Howells
2010-01-06 17:23 ` [PATCH 4/4] elf_fdpic_core_dump(): fix build break in 2.6.33-rc1 David Howells
2010-01-06 17:26 ` Paul Mundt
2010-01-06 18:45 ` Linus Torvalds [this message]
2010-01-07 0:12 ` David Howells
-- strict thread matches above, loose matches on Subject: below --
2009-12-22 17:17 [PATCH 1/4] FDPIC: Respect PT_GNU_STACK exec protection markings when creating NOMMU stack David Howells
2009-12-22 17:17 ` [PATCH 4/4] elf_fdpic_core_dump(): fix build break in 2.6.33-rc1 David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1001061044000.3630@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=d.hatayama@jp.fujitsu.com \
--cc=dhowells@redhat.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=uclinux-dev@uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome