mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@elte.hu>,
	Peter Zijlstra <peterz@infradead.org>
Subject: Re: [2.6.33-rc5] Weird deadlock when shutting down
Date: Thu, 18 Feb 2010 08:31:03 -0800 (PST)	[thread overview]
Message-ID: <alpine.LFD.2.00.1002180825000.4141@localhost.localdomain> (raw)
In-Reply-To: <1266485775.6539.6.camel@jlt3.sipsolutions.net>



On Thu, 18 Feb 2010, Johannes Berg wrote:
> >  
> > Basically, the machine deadlocks right after printing the following
> > when doing a shutdown:
> > 
> > halt/4071 is trying to acquire lock:
> >  (s_active){++++.+}, at: [<c0000000001ef868>]
> > .sysfs_addrm_finish+0x58/0xc0
> > 
> > but task is already holding lock:
> >  (&per_cpu(cpu_policy_rwsem, cpu)){+.+.+.}, at: [<c0000000004cd6ac>]
> > .lock_policy_rwsem_write+0x84/0xf4
> > 
> > which lock already depends on the new lock.

You don't have a full backtrace for these things?

We've had lots of trouble with the cpu governors, and I suspect the 
problem isn't new, but the lockdep warning is likely new (see commit 
846f99749ab68bbc7f75c74fec305de675b1a1bf: "sysfs: Add lockdep annotations 
for the sysfs active reference").

So it is likely to be an old issue that (a) now gets warned about and (b) 
might have had timing changes enough to trigger it.

I suspect it is G5-specific (or specific to whatever CPU frequency code 
that gets used there), since I think we'd have had lots of reports if this 
happened on x86.

		Linus

  reply	other threads:[~2010-02-18 16:32 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-29  4:41 Benjamin Herrenschmidt
2010-02-18  9:36 ` Johannes Berg
2010-02-18 16:31   ` Linus Torvalds [this message]
2010-02-18 18:45     ` Johannes Berg
2010-02-20  7:13       ` Américo Wang
2010-02-20  8:56         ` Johannes Berg
2010-02-20  9:06           ` Américo Wang
2010-02-20 10:53             ` Johannes Berg
2010-02-20 11:28             ` Johannes Berg
2010-02-20 12:07               ` Johannes Berg
2010-02-20 13:44               ` Américo Wang
2010-02-20 13:57                 ` Johannes Berg
2010-02-21  9:51                   ` Américo Wang
2010-02-21 10:17                     ` Johannes Berg
2010-02-22  8:19                       ` Américo Wang
2010-02-22  8:39                         ` Johannes Berg
2010-02-21 10:43                     ` Johannes Berg
2010-02-21 10:55                       ` Xiaotian Feng
2010-02-21 11:12                         ` Xiaotian Feng
2010-02-21 11:14                           ` Johannes Berg
2010-02-21 11:22                             ` Johannes Berg
2010-02-22  8:34                               ` Américo Wang
2010-02-22  9:04                                 ` Johannes Berg
2010-02-22  9:12                                   ` Américo Wang
2010-02-22  9:14                                     ` Johannes Berg
2010-02-22  9:21                                       ` Américo Wang
2010-02-22  8:22                           ` Américo Wang
2010-02-20  7:42       ` Dave Young
2010-02-20  8:46         ` Johannes Berg
2010-02-20  4:46     ` Américo Wang
2010-02-20  8:45       ` Johannes Berg
2010-02-20  9:30   ` Américo Wang
2010-02-20 10:52     ` Johannes Berg
2010-03-25 11:28 ` David Howells
2010-03-26  2:43   ` Américo Wang
2010-03-26 12:22   ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.1002180825000.4141@localhost.localdomain \
    --to=torvalds@linux-foundation.org \
    --cc=benh@kernel.crashing.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome