From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936282Ab0B0Vdq (ORCPT ); Sat, 27 Feb 2010 16:33:46 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:48942 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933964Ab0B0Vdo (ORCPT ); Sat, 27 Feb 2010 16:33:44 -0500 Date: Sat, 27 Feb 2010 13:33:21 -0800 (PST) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Eric Paris cc: viro@zeniv.linux.org.uk, hch@infradead.org, linux-kernel@vger.kernel.org Subject: Re: [GIT PULL] notification: including fanotify In-Reply-To: Message-ID: References: <1267218869.10582.12.camel@localhost> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 27 Feb 2010, Linus Torvalds wrote: > > (b) the compile has obviously never been tested with any modern gcc > version. I get tons of warnings after the pull, like In fact, this seems to be due to a commit that explicitly says: I do not add -Wpointer-sign to the fsnotify code as there are still issues with kstrdup and strlen which would pop out needless warnings. but then the patch actually has --- a/fs/notify/Makefile +++ b/fs/notify/Makefile @@ -1,3 +1,5 @@ +EXTRA_CFLAGS += -Wpointer-sign + WTF? Which part of this was tested AT ALL? Clearly there was not even a compile test going on. Linus