From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752043Ab0CBIbw (ORCPT ); Tue, 2 Mar 2010 03:31:52 -0500 Received: from www.tglx.de ([62.245.132.106]:51985 "EHLO www.tglx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750885Ab0CBIbv (ORCPT ); Tue, 2 Mar 2010 03:31:51 -0500 Date: Tue, 2 Mar 2010 09:31:13 +0100 (CET) From: Thomas Gleixner To: "Eric W. Biederman" cc: Ian Campbell , Yinghai Lu , mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org, mingo@elte.hu, linux-tip-commits@vger.kernel.org, Jeremy Fitzhardinge Subject: Re: [tip:x86/irq] x86: apic: Fix mismerge, add arch_probe_nr_irqs() again In-Reply-To: Message-ID: References: <20100207210250.GB8256@jenkins.home.ifup.org> <4B881097.1050505@kernel.org> <1267442545.11737.20718.camel@zakaz.uk.xensource.com> <1267479860.2785.843.camel@localhost.localdomain> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 1 Mar 2010, Eric W. Biederman wrote: > Ian Campbell writes: > > On Mon, 2010-03-01 at 10:34 -0800, Eric W. Biederman wrote: > It is going to take a bit but our next big step for the irq methods > is to make them all take struct irq_desc pointers instead of unsigned > int irq, so we don't have to repeat the lookups. That should hit 2.6.35. > >> - Xen has an array irq_info[NR_IRQS] one of the last static arrays > >> sized at NR_IRQs in the entire kernel. > > > > Hopefully the same info as is in that array could (and indeed should) be > > instead stored in irq_desc->chip_data. Would you object to > > arch_init_copy_chip_data and arch_free_chip_data becoming function > > pointers within the struct irq_chip? > > No objections. Now that I see those methods it looks like they always > should have been in irq_chip. Agreed. Thanks, tglx