From: Linus Torvalds <torvalds@linux-foundation.org>
To: Phillip Lougher <phillip@lougher.demon.co.uk>
Cc: Linux Kernel Development <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Alain Knaff <alain@knaff.lu>
Subject: Re: [GIT PULL] Squashfs updates for 2.6.34
Date: Wed, 3 Mar 2010 09:08:45 -0800 (PST) [thread overview]
Message-ID: <alpine.LFD.2.00.1003030904040.3627@localhost.localdomain> (raw)
In-Reply-To: <4B8C1873.1080700@lougher.demon.co.uk>
On Mon, 1 Mar 2010, Phillip Lougher wrote:
>
> Please pull the following Squashfs updates. They add support
> for lzma compressed file systems, plus there's also a couple of
> trivial code tidy patches.
No. I'm not pulling this.
> include/linux/decompress/bunzip2_mm.h | 13 +++
> include/linux/decompress/inflate_mm.h | 13 +++
> include/linux/decompress/mm.h | 4 -
> include/linux/decompress/unlzma_mm.h | 20 +++++
> include/linux/decompress/unlzo_mm.h | 13 +++
What the _h*ll_ is the point of these totally illogical and ugly files?
The name makes no sense, and the _contents_ make zero sense either.
Please. Don't add more ugly generic header files into the main include
directory. I realize that the ugliness is partly historical (that
"<linux/decompress/mm.h>" file sure as hell was messy to begin with), but
this just makes that crazy situation worse.
Clean up the mess instead of making it even less understandable. Please.
That whole "#ifdef STATIC" crap needs to go - not get spread out even
more.
Linus
next prev parent reply other threads:[~2010-03-03 17:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-01 19:41 Phillip Lougher
2010-03-03 17:08 ` Linus Torvalds [this message]
2010-03-04 1:17 ` Phillip Lougher
2010-03-04 3:49 ` Linus Torvalds
2010-03-04 4:52 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1003030904040.3627@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=alain@knaff.lu \
--cc=linux-kernel@vger.kernel.org \
--cc=phillip@lougher.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®