From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754003Ab0CDQGg (ORCPT ); Thu, 4 Mar 2010 11:06:36 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:55656 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752018Ab0CDQGf (ORCPT ); Thu, 4 Mar 2010 11:06:35 -0500 Date: Thu, 4 Mar 2010 08:06:12 -0800 (PST) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Oleg Nesterov cc: Andrew Morton , Roland McGrath , wylda@volny.cz, gregkh@suse.de, jkosina@suse.cz, Sukadev Bhattiprolu , Serge Hallyn , linux-kernel@vger.kernel.org Subject: Re: [PATCH] pid_ns: zap_pid_ns_processes: use SEND_SIG_NOINFO instead of force_sig() In-Reply-To: <20100303202650.GA15521@redhat.com> Message-ID: References: <20100302201646.GA10734@redhat.com> <20100303013227.4FFDE89EB@magilla.sf.frob.com> <20100303112343.B89802F@magilla.sf.frob.com> <20100303184412.GA7816@redhat.com> <20100303193003.GA10734@redhat.com> <20100303202650.GA15521@redhat.com> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 3 Mar 2010, Oleg Nesterov wrote: > > zap_pid_ns_processes() uses force_sig(SIGKILL) to ensure SIGKILL > will be delivered to sub-namespace inits as well. This is correct, > but we are going to change force_sig_info() semantics. > See http://bugzilla.kernel.org/show_bug.cgi?id=15395#c31 > > We can use send_sig_info(SEND_SIG_NOINFO) instead, since > 614c517d7c00af1b26ded20646b329397d6f51a1 SEND_SIG_NOINFO means > "from user" and therefore send_signal() will get the correct > from_ancestor_ns = T flag. > > Signed-off-by: Oleg Nesterov Acked-by: Linus Torvalds Linus