From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756849Ab0CDTLk (ORCPT ); Thu, 4 Mar 2010 14:11:40 -0500 Received: from www.tglx.de ([62.245.132.106]:49987 "EHLO www.tglx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755274Ab0CDTLj (ORCPT ); Thu, 4 Mar 2010 14:11:39 -0500 Date: Thu, 4 Mar 2010 20:08:55 +0100 (CET) From: Thomas Gleixner To: Yinghai Lu cc: Ingo Molnar , "H. Peter Anvin" , Andrew Morton , Suresh Siddha , Eric Biederman , LKML , Julia Lawall Subject: Re: [PATCH 06/12] genericirq: make irq_chip related function to take desc In-Reply-To: <4B900250.8020100@kernel.org> Message-ID: References: <1267697339-5491-1-git-send-email-yinghai@kernel.org> <1267697339-5491-7-git-send-email-yinghai@kernel.org> <4B900250.8020100@kernel.org> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 4 Mar 2010, Yinghai Lu wrote: > On 03/04/2010 06:31 AM, Thomas Gleixner wrote: > > The code which uses the chip functions needs to be changed: > > > > - desc->chip->fun(irq); > > + desc->chip->fun(desc); > > > > That's mostly in kernel/irq/* but there are some users in arch/* > > lowlevel irq handling code as well. > > that is our -v2 version. I know, but the difference is that it is done by a machine. I have been involved in more than one large scale overhaul projects in the kernel and most of the time I spent on those was to figure out the right way to do it to limit the risks. Automated conversion is the best thing you can do and if Julia can whip up that rules, I'm less worried about the wholesale switchover on a per function basis, than I'm scared about the fully manual approach you took. Thanks, tglx