From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755865Ab0CEWkm (ORCPT ); Fri, 5 Mar 2010 17:40:42 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:55197 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755836Ab0CEWkl (ORCPT ); Fri, 5 Mar 2010 17:40:41 -0500 Date: Fri, 5 Mar 2010 14:40:33 -0800 (PST) From: Linus Torvalds X-X-Sender: torvalds@localhost.localdomain To: Jeff Chua cc: Linux Kernel , Oliver Neukum , Greg Kroah-Hartman , Frederic Weisbecker , petr@vmware.com, Eli Collins Subject: Re: commit 554f76962d3a6eb5110415f1591aca83f96a84ae hangs USB for vmware 7.0.1 In-Reply-To: Message-ID: References: User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 6 Mar 2010, Jeff Chua wrote: > > Linux version v2.6.33-5399-gcc7889f with reiser3 and vmware-7.0.1 > > Starting vmware just hang even before displaying the main GUI. Reverting > 554f76962d3a6eb5110415f1591aca83f96a84ae solves the problem. > > It seems vmware is trying to access the USB but this commit blocks it. > > So, is this a vmware problem or shall this be reverted? It's almost certainly a deadlock through some path that wasn't tested. Can you enable lockdep on that kernel when you run vmware, which should give us a nice callchain etc, and hopefully make it very obvious what goes on. Reverting it is obviously an option, but with some more info maybe there's a better solution. (It may be that the deadlock is obvious to Oliver/Greg even without any lockdep chains, of course, but still worth trying, I suspect) Linus