From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752792Ab0CTCoo (ORCPT ); Fri, 19 Mar 2010 22:44:44 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:55088 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752652Ab0CTCom (ORCPT ); Fri, 19 Mar 2010 22:44:42 -0400 Date: Fri, 19 Mar 2010 19:41:05 -0700 (PDT) From: Linus Torvalds To: Yinghai Lu cc: "H. Peter Anvin" , Ingo Molnar , Thomas Gleixner , linux-kernel@vger.kernel.org, Ian Campbell , Peter Zijlstra Subject: Re: [PATCH -v5] x86: do not free zero sized per cpu areas In-Reply-To: <4BA42C05.3060800@kernel.org> Message-ID: References: <4B914A61.20409@kernel.org> <4BA3F82D.5090807@kernel.org> <4BA3F8ED.2090600@zytor.com> <4BA407B8.7070503@kernel.org> <4BA408EE.5000001@zytor.com> <4BA40C83.1030202@kernel.org> <4BA42C05.3060800@kernel.org> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 19 Mar 2010, Yinghai Lu wrote: > + if (WARN_ONCE(start > end, > + "free_early_partial got wrong start/end %#llx/%#llx\n", > + start, end)) I really don't want multi-line single statements like this. Shorten the string a bit, and it should all fit fine on one line, and be much more greppable. Linus