mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Pavel Machek <pavel@ucw.cz>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	Alexey Dobriyan <adobriyan@gmail.com>,
	kernel list <linux-kernel@vger.kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@osdl.org>
Subject: Re: LOCALVERSION_AUTO considered harmful
Date: Mon, 12 Apr 2010 00:24:10 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LFD.2.00.1004120022230.18009@localhost.localdomain> (raw)
In-Reply-To: <20100411201426.GC25294@elf.ucw.cz>

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1297 bytes --]

On Sun, 11 Apr 2010, Pavel Machek wrote:

> On Sun 2010-04-11 20:58:58, Geert Uytterhoeven wrote:
> > On Mon, Apr 12, 2010 at 20:51, Alexey Dobriyan <adobriyan@gmail.com> wrote:
> > > On Sun, Apr 11, 2010 at 06:47:01PM +0200, Pavel Machek wrote:
> > >> @@ -99,6 +98,11 @@ config LOCALVERSION_AUTO
> > >>         appended after any matching localversion* files, and after the value
> > >>         set in CONFIG_LOCALVERSION.
> > >>
> > >> +       Unfortunately, such finegrained versioning will mean that you will
> > >> +       not be able to use modules for development; even "make modules"
> > >> +       will change module versions, making recompiled modules impossible
> > >> +       to insert into old kernel.
> > >
> > > That's conditional BS.
> > > Turn off CONFIG_MODVERSIONS already.
> > 
> > Yeah, I disabled it ages ago. Even then (before git, probably even
> > before bitkeeper)
> > I had hard times inserting modules...
> 
> I _had_ it off
> 
>  # CONFIG_MODVERSIONS is not set
> 
> It seems some checking survives CONFIG_MODVERSIONS unset and that
> checking is strict enough to refuse module load after one "make
> modules" with LOCALVERSION_AUTO on...

So instead of fixing the CONFIG_MODVERSIONS=n case you go the easy way
of killing LOCALVERSION_AUTO ? Brilliant.

Thanks,

	tglx

  reply	other threads:[~2010-04-11 22:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-11 16:47 Pavel Machek
2010-04-12 18:51 ` Alexey Dobriyan
2010-04-11 18:58   ` Geert Uytterhoeven
2010-04-11 20:14     ` Pavel Machek
2010-04-11 22:24       ` Thomas Gleixner [this message]
2010-04-12  1:20         ` rdunlap
2010-04-12  2:56         ` rdunlap
2010-04-12  3:49           ` Randy Dunlap
2010-04-12 12:48           ` Theodore Tso
2010-04-12 13:14         ` Pavel Machek
2010-04-12 17:03           ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.1004120022230.18009@localhost.localdomain \
    --to=tglx@linutronix.de \
    --cc=adobriyan@gmail.com \
    --cc=akpm@osdl.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®