mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Ingo Molnar <mingo@elte.hu>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Mike Galbraith <efault@gmx.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Greg Kroah-Hartman <greg@kroah.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Jarkko Nikula <jhnikula@gmail.com>,
	Tony Lindgren <tony@atomide.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC patch] CFS fix place entity spread issue (v2)
Date: Sun, 18 Apr 2010 13:21:13 -0700 (PDT)	[thread overview]
Message-ID: <alpine.LFD.2.00.1004181317100.14500@i5.linux-foundation.org> (raw)
In-Reply-To: <20100418131302.GA3614@Krystal>



On Sun, 18 Apr 2010, Mathieu Desnoyers wrote:
>
> CFS fix place entity spread issue (v2)
> 
> Huge CFS vruntime spread (18 minutes) has been observed with LTTng while simply
> running Xorg on a uniprocessor machine. Detailed explanation in my ELC2010
> presentation at:

Hmm. I tested this patch with my favourite non-scientific desktop load 
test: do web browsing while doing a kernel compile with "make -j16" (after 
doing a "git clean -dqfx" and "ccache -C" to get rid of old object files 
and ccache).

This is on a dual-core (with SMT, so 4 threads) Core i5, so "make -j16" 
overcommits the CPU's quite a bit.

And quite frankly, I think your patch makes things much worse. I don't 
have numbers, but it felt much choppier and slower to do scrolling in 
firefox o moving windows around while the load average is 20+.

My testload is in no way objective, nor necessarily any good, but it's the 
one I happen to use, and while it's subjective, I think the difference was 
pretty clear and not good.

			Linus

  reply	other threads:[~2010-04-18 20:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-18 13:13 Mathieu Desnoyers
2010-04-18 20:21 ` Linus Torvalds [this message]
2010-04-18 22:59   ` Mathieu Desnoyers
2010-04-18 23:23     ` Linus Torvalds
2010-04-19  9:25 ` Peter Zijlstra
2010-04-19 14:06   ` Mathieu Desnoyers
2010-04-19 14:43     ` Peter Zijlstra
2010-04-19 14:43 ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.1004181317100.14500@i5.linux-foundation.org \
    --to=torvalds@linux-foundation.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=efault@gmx.de \
    --cc=greg@kroah.com \
    --cc=jhnikula@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®