From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754579Ab0DVSPY (ORCPT ); Thu, 22 Apr 2010 14:15:24 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:48292 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753585Ab0DVSPX (ORCPT ); Thu, 22 Apr 2010 14:15:23 -0400 Date: Thu, 22 Apr 2010 11:12:41 -0700 (PDT) From: Linus Torvalds To: Ingo Molnar cc: Neil Brown , linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: tip: origin tree build failure (x86, 32-bit, allyesconfig) In-Reply-To: <20100422070610.GA18884@elte.hu> Message-ID: References: <19350.53522.385933.467438@notabene.brown> <20100422070610.GA18884@elte.hu> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 22 Apr 2010, Ingo Molnar wrote: > > All 32-bit x86 builds (x86, allyesconfig) that enable RAID are failing with > this build failure: > > drivers/built-in.o: In function `raid5_compute_sector': > raid5.c:(.text+0x2e42ac): undefined reference to `__umoddi3' > raid5.c:(.text+0x2e42d8): undefined reference to `__umoddi3' > raid5.c:(.text+0x2e42ff): undefined reference to `__umoddi3' > raid5.c:(.text+0x2e4327): undefined reference to `__umoddi3' > raid5.c:(.text+0x2e4385): undefined reference to `__umoddi3' > drivers/built-in.o:raid5.c:(.text+0x2e43bc): more undefined references to `__umoddi3' follow > > Caused by this commit: > > 35f2a59: md/raid5: allow for more than 2^31 chunks. Gaah, yes. How about just making it "unsigned long" instead of sector_t, and telling people that if they have more than 2**32 chunks in their RAID array, they should damn well use a 64-bit CPU. The alternative, of course, is to use "sector_div()" everywhere. Neil? Linus