From: Len Brown <lenb@kernel.org>
To: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
Cc: linux-acpi@vger.kernel.org, rui.zhang@intel.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ACPI: fix fan module removal when ACPI_PROCFS is disabled
Date: Tue, 27 Apr 2010 13:12:49 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.00.1004271309190.4006@localhost.localdomain> (raw)
In-Reply-To: <1272385158-4080-1-git-send-email-cascardo@holoscopio.com>
> When ACPI_PROCFS is disabled, /proc/acpi/fan/ directory is not created.
> So, it should not be removed during the module removal either.
Yes, this patch would make the #ifdefs consistent.
But it looks like remove_proc_entry() just silently does nothing
if the directory is not there, yes?
What I'd really like to see is a patch removing fan.c's proc code
completely. It was scheduld for removal in July 2008.
thanks,
Len Brown, Intel Open Source Technology Center
next prev parent reply other threads:[~2010-04-27 17:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-27 16:19 Thadeu Lima de Souza Cascardo
2010-04-27 17:12 ` Len Brown [this message]
2010-04-27 17:18 ` Thadeu Lima de Souza Cascardo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1004271309190.4006@localhost.localdomain \
--to=lenb@kernel.org \
--cc=cascardo@holoscopio.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®