From: Linus Torvalds <torvalds@linux-foundation.org>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: linux-kernel@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH 2/2] vgacon: use request_region(), not request_resource(), to set BUSY
Date: Tue, 4 May 2010 12:09:46 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.2.00.1005041207380.5478@i5.linux-foundation.org> (raw)
In-Reply-To: <20100504185806.7244.96960.stgit@bob.kio>
On Tue, 4 May 2010, Bjorn Helgaas wrote:
>
> Drivers normally use request_region() to mark the region busy so it won't
> be used by anybody else. Previously, we used request_resource(), which
> doesn't mark the VGA regions busy.
>
> Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Hmm. I don't object, but unless there is some crazy regression, there's no
way I will take something like this outside the merge window. Who knows
what odd frame buffer driver is out there that just depended on the fact
that it could also register that VGA area?
Probably no such thing exists, but it's why I want these kinds of things
during the merge window. And obviously preferably through something like
the PCI merge tree, but that's a different issue.
Linus
next prev parent reply other threads:[~2010-05-04 19:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-04 18:58 [PATCH 1/2] resources: fill in type for __request_region() Bjorn Helgaas
2010-05-04 18:58 ` [PATCH 2/2] vgacon: use request_region(), not request_resource(), to set BUSY Bjorn Helgaas
2010-05-04 19:09 ` Linus Torvalds [this message]
2010-05-04 19:16 ` Bjorn Helgaas
2010-05-04 20:14 ` H. Peter Anvin
2010-05-04 20:51 ` Jesse Barnes
2010-05-18 21:41 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1005041207380.5478@i5.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=bjorn.helgaas@hp.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®