From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752766Ab0EHTx5 (ORCPT ); Sat, 8 May 2010 15:53:57 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:57773 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752119Ab0EHTx4 (ORCPT ); Sat, 8 May 2010 15:53:56 -0400 Date: Sat, 8 May 2010 12:51:08 -0700 (PDT) From: Linus Torvalds To: Andrea Arcangeli cc: Mel Gorman , Andrew Morton , Linux-MM , LKML , Minchan Kim , KAMEZAWA Hiroyuki , Christoph Lameter , Rik van Riel , Peter Zijlstra Subject: Re: [PATCH 1/2] mm,migration: Prevent rmap_walk_[anon|ksm] seeing the wrong VMA information In-Reply-To: <20100508180412.GT5941@random.random> Message-ID: References: <1273188053-26029-1-git-send-email-mel@csn.ul.ie> <1273188053-26029-2-git-send-email-mel@csn.ul.ie> <20100508153922.GS5941@random.random> <20100508180412.GT5941@random.random> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 8 May 2010, Andrea Arcangeli wrote: > > There is no broken (as in kernel crashing) locking in my THP > patches. It's not about crashing. It's about being a totally unmaintainable mess, with ad-hoc temporary allocations, and loops over an unknown number of spinlocks. That's _broken_. B. R. O. K. E. N. And in all cases there are fixes that I've pointed out. If you can't see that, then that's _your_ problem. If you (or others) want your code merged, then it had better _fix_ the total disaster before merging. It's that simple. The "lock root" thing you complain should also be easily fixable, by keeping the root lock a separate issue from walking the actual anon_vma (ie walk the anon_vma, but lock the root). You still don't have to lock the whole list. Linus