From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754273Ab0EQIHd (ORCPT <rfc822;w@1wt.eu>);
	Mon, 17 May 2010 04:07:33 -0400
Received: from www.tglx.de ([62.245.132.106]:33830 "EHLO www.tglx.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752466Ab0EQIHb (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 17 May 2010 04:07:31 -0400
Date: Mon, 17 May 2010 10:07:05 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Feng Tang <feng.tang@intel.com>
cc: Ingo Molnar <mingo@elte.hu>, "H.Peter Anvin" <hpa@zytor.com>,
       "Brown, Len" <len.brown@intel.com>, LKML <linux-kernel@vger.kernel.org>,
       "Pan, Jacob jun" <jacob.jun.pan@intel.com>,
       Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH] x86: unify current 3 similar ways of saving IRQ info
In-Reply-To: <20100517153156.4439d62b@feng-i7>
Message-ID: <alpine.LFD.2.00.1005171004500.3368@localhost.localdomain>
References: <20100517153156.4439d62b@feng-i7>
User-Agent: Alpine 2.00 (LFD 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 17 May 2010, Feng Tang wrote:

>  
> -static void __init assign_to_mp_irq(struct mpc_intsrc *m,

  Why are you removing __init ?

> +static void assign_to_mp_irq(struct mpc_intsrc *m,
>  				    struct mpc_intsrc *mp_irq)
>  {
>  	mp_irq->dstapic = m->dstapic;
> @@ -190,7 +190,7 @@ static void __init assign_to_mpc_intsrc(struct mpc_intsrc *mp_irq,
>  	m->dstirq = mp_irq->dstirq;
>  }
>  
> -static int __init mp_irq_mpc_intsrc_cmp(struct mpc_intsrc *mp_irq,
> +static int mp_irq_mpc_intsrc_cmp(struct mpc_intsrc *mp_irq,
>  					struct mpc_intsrc *m)

  Ditto

>  {
>  	if (mp_irq->dstapic != m->dstapic)
> @@ -211,7 +211,8 @@ static int __init mp_irq_mpc_intsrc_cmp(struct mpc_intsrc *mp_irq,
>  	return 0;
>  }
>  
> -static void __init MP_intsrc_info(struct mpc_intsrc *m)
> +/* Will also be called in acpi/sfi related code */
> +void mp_save_irq(struct mpc_intsrc *m)

  Again, this code is called from __init context only and should stay
  __init.

Thanks,

	tglx