From: Linus Torvalds <torvalds@linux-foundation.org>
To: linux-kernel@vger.kernel.org, mingo@redhat.com, hpa@zytor.com,
arjan@linux.intel.com, tglx@linutronix.de
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:timers/urgent] timers: Fix slack calculation really
Date: Tue, 25 May 2010 12:12:52 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.2.00.1005251211470.3689@i5.linux-foundation.org> (raw)
In-Reply-To: <tip-8e63d7795e30b4091e303cc8c060509bd8eea742@git.kernel.org>
On Tue, 25 May 2010, tip-bot for Thomas Gleixner wrote:
> {
> - unsigned long expires_limit, mask;
> + unsigned long expires_limit, mask, now;
> int bit;
>
> expires_limit = expires;
>
> - if (timer->slack > -1)
> + if (timer->slack >= 0) {
> expires_limit = expires + timer->slack;
> - else if (time_after(expires, jiffies)) /* auto slack: use 0.4% */
> - expires_limit = expires + (expires - jiffies)/256;
> -
> + } else {
> + now = jiffies;
So this works, but I'd really suggest that you actually nest the
declarations correctly too.
Linus
parent reply other threads:[~2010-05-25 19:16 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <tip-8e63d7795e30b4091e303cc8c060509bd8eea742@git.kernel.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1005251211470.3689@i5.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®