From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751372Ab0E3Qbs (ORCPT ); Sun, 30 May 2010 12:31:48 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:54692 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750913Ab0E3Qbr (ORCPT ); Sun, 30 May 2010 12:31:47 -0400 Date: Sun, 30 May 2010 09:28:09 -0700 (PDT) From: Linus Torvalds To: Samuel Ortiz cc: linux-kernel Subject: Re: [GIT] [2.6.35] MFD pull request In-Reply-To: <20100528004611.GA24790@sortiz.org> Message-ID: References: <20100528004611.GA24790@sortiz.org> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 28 May 2010, Samuel Ortiz wrote: > > This is the MFD pull request for the 2.6.35 merge window. Samuel - this adds the CONFIG_MFD thing, with absolutely _no_ explanation. So now people see this totally incomprehensible question: Enable Multifunction device drivers? (Y/n) with no sane way to decide whether they should actually enable it or not. I'm ok with it being 'y' default, since it's a whole new config option that enables pre-existing config options, but _dammit_ people, you need to think way more about the Kconfig options you add! "MFD" isn't even a well-defined term. A lot of people think about printers when they hear it. So you really _really_ need to explain what the h*ll you are asking people! Linus