mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: David Howells <dhowells@redhat.com>
Cc: akpm@linux-foundation.org, uclinux-dev@uclinux.org,
	linux-kernel@vger.kernel.org,
	uclinux-dist-devel@blackfin.uclinux.org,
	Mike Frysinger <vapier@gentoo.org>
Subject: Re: [PATCH] NOMMU: Add '[stack]' label to /proc/pid/maps output
Date: Tue, 1 Jun 2010 12:07:52 -0700 (PDT)	[thread overview]
Message-ID: <alpine.LFD.2.00.1006011204270.8175@i5.linux-foundation.org> (raw)
In-Reply-To: <20100601185937.5188.77506.stgit@warthog.procyon.org.uk>



On Tue, 1 Jun 2010, David Howells wrote:
>
> From: Mike Frysinger <vapier@gentoo.org>
> 
> Add support to the NOMMU /proc/pid/maps file to show which mapping is the stack
> of the original thread after execve.  This is largely based on the MMU code.

Umm? The MMU code that we _reverted_?

It turns out to be totally useless, since people put stacks in various 
different places, and the values the kernel does see end up not even being 
the "real" stack top.

See commit 34441427aab4bdb3069a4ffcda69a99357abcb2e.

Just don't do it.

		Linus

  reply	other threads:[~2010-06-01 19:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-01 18:59 David Howells
2010-06-01 19:07 ` Linus Torvalds [this message]
2010-06-01 20:52   ` [Uclinux-dist-devel] " Mike Frysinger
2010-06-01 21:05     ` Linus Torvalds
2010-06-04 20:48 ` Andrew Morton
2010-06-04 23:00   ` [Uclinux-dist-devel] " Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.1006011204270.8175@i5.linux-foundation.org \
    --to=torvalds@linux-foundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=uclinux-dev@uclinux.org \
    --cc=uclinux-dist-devel@blackfin.uclinux.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®