From: Linus Torvalds <torvalds@linux-foundation.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Tejun Heo <tj@kernel.org>, David Howells <dhowells@redhat.com>,
davem@davemloft.net, jens.axboe@oracle.com,
linux-kernel@vger.kernel.org, viro@ZenIV.linux.org.uk,
Nick Piggin <nickpiggin@yahoo.com.au>
Subject: Re: [PATCH] fs: run emergency remount on dedicated workqueue
Date: Tue, 1 Jun 2010 16:57:44 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.2.00.1006011651580.8175@i5.linux-foundation.org> (raw)
In-Reply-To: <20100601164603.39dfedf7.akpm@linux-foundation.org>
On Tue, 1 Jun 2010, Andrew Morton wrote:
>
> Please, always quote the patch title rather than a bare commit ID. The
> usual form is
>
> fa4b9074cd8428958c2adf9dc0c831f46e27c193 ("buffer: make
> invalidate_bdev() drain all percpu LRU add caches:)
>
> The main reason for this is so that people can more reliably and simply
> identify the patch within a different tree. I think.
Absolutely. Also, I think it's usually more readable to quote just the
first 12 hex digits of the SHA1 - that's still going to be perfectly
unique in any practical situation, and makes it way easier to flow the
text to be readable.
> gaah. Do we really want to add Yet Another Kernel Thread just for that
> dopey sysrq-U thing?
I do have to agree that it's disgusting. Can't we use an existing thread
(slow-work?) or something like that?
Linus
next prev parent reply other threads:[~2010-06-02 0:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 15:01 Change to invalidate_bdev() may break emergency remount R/O David Howells
2010-05-27 9:57 ` [PATCH] fs: run emergency remount on dedicated workqueue Tejun Heo
2010-05-27 14:59 ` Américo Wang
2010-05-27 17:03 ` Tejun Heo
2010-05-28 6:46 ` Américo Wang
2010-06-01 23:46 ` Andrew Morton
2010-06-01 23:57 ` Linus Torvalds [this message]
2010-06-02 0:13 ` Tejun Heo
2010-06-02 1:02 ` Dave Young
2010-06-02 1:57 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1006011651580.8175@i5.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=tj@kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®