From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756631Ab0I3UJQ (ORCPT ); Thu, 30 Sep 2010 16:09:16 -0400 Received: from www.tglx.de ([62.245.132.106]:39718 "EHLO www.tglx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754793Ab0I3UJO (ORCPT ); Thu, 30 Sep 2010 16:09:14 -0400 Date: Thu, 30 Sep 2010 22:08:15 +0200 (CEST) From: Thomas Gleixner To: Phil Carmody cc: arjan@linux.intel.com, akpm@linux-foundation.org, mingo@elte.hu, linux-kernel@vger.kernel.org, Artem.Bityutskiy@nokia.com Subject: Re: timer: permit statically-declared work with deferrable timers In-Reply-To: <1285874789-1481-1-git-send-email-ext-phil.2.carmody@nokia.com> Message-ID: References: <1285874789-1481-1-git-send-email-ext-phil.2.carmody@nokia.com> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 30 Sep 2010, Phil Carmody wrote: > > Arjen, Thomas, > > This patch is an enabler which hopefully can lead to simplification of code > elsewhere. For example, it would turn Artem's patch I refer to in the commit > message (8eab945c5616fc984e97b922d6a2559be93f39a1) into just: > > -static DECLARE_DELAYED_WORK(cache_cleaner, do_cache_clean); > +static DECLARE_DEFERRED_WORK(cache_cleaner, do_cache_clean); > > rather than the creation of a __init helper that required touching 3 files. > > I'm prepared to follow up with such simplifying patches if it's considered > worthwhile. If it simplies stuff, no objections from my side. The patch looks reasonable enough. How many (ab)users will it clean up ? Thanks, tglx