mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Richard Weinberger <richard@nod.at>
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com, hpa@zytor.com,
	linux-tip-commits@vger.kernel.org
Subject: Re: [tip:irq/core] genirq: Warn if enable_irq is called before irq is set up
Date: Fri, 22 Oct 2010 16:09:17 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LFD.2.00.1010221608400.14359@localhost6.localdomain6> (raw)
In-Reply-To: <2ae2295020fc2c103ca624e08e43c849@radon2.swed.at>

On Fri, 22 Oct 2010, Richard Weinberger wrote:
> On Fri, 22 Oct 2010 13:09:49 GMT, tip-bot for Thomas Gleixner
> > @@ -324,6 +324,10 @@ void enable_irq(unsigned int irq)
> >  	if (!desc)
> >  		return;
> >  
> > +	if (WARN(!desc->irq_data.chip || !desc->irq_data.chip->irq_enable,
> > +	    "KERN_ERR enable_irq before setup/request_irq: irq %u\n", irq))
> 
> Here is a little typo. The double quote should be after KERN_ERR.

Crap, yes. It still compiles :)

Thanks,

	tglx

      reply	other threads:[~2010-10-22 14:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <tip-658fc358f9954083ea55abf82ca77a18f82412d7@git.kernel.org>
2010-10-22 13:43 ` Richard Weinberger
2010-10-22 14:09   ` Thomas Gleixner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.1010221608400.14359@localhost6.localdomain6 \
    --to=tglx@linutronix.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®