mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Abhijeet Dharmapurikar <adharmap@codeaurora.org>
Cc: Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-msm-owner@vger.kernel.org
Subject: Re: [RFC IRQ] genirq: fix handle_nested_irq for lazy disable
Date: Thu, 28 Oct 2010 20:52:54 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LFD.2.00.1010282050390.2692@localhost6.localdomain6> (raw)
In-Reply-To: <4CC9B167.8010401@codeaurora.org>

On Thu, 28 Oct 2010, Abhijeet Dharmapurikar wrote:
> Thomas Gleixner wrote:
> > Aside of that this wont work for edge triggered interrupts, as you'd
> > loose the edge, so this needs more thought and a thorough look at the
> > users of handle_nested_irq().
> 
> I didn't understand this though. This patch will mask the interrupt in the
> controller even if it were edge. My interrupt controller latches
> edges and wants a mask (or an ack) to be executed to deactivate the line
> summary line. Do you mean that I should mark the interrupt IRQ_PENDING if it
> were an edge before masking it? If not, can you please explain.

See handle_edge_irq().

An edge is a one time event. Once you mask/ack it, it's gone. So now
when you unmask it won't reissue the interrupt on the hardware
level. Level interrupts do, as the mask does not affect that.

Thanks,

	tglx

  reply	other threads:[~2010-10-28 18:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-27  1:50 adharmap
2010-10-27  8:01 ` Thomas Gleixner
2010-10-28 17:22   ` Abhijeet Dharmapurikar
2010-10-28 18:52     ` Thomas Gleixner [this message]
2010-10-29  0:04       ` Abhijeet Dharmapurikar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.1010282050390.2692@localhost6.localdomain6 \
    --to=tglx@linutronix.de \
    --cc=adharmap@codeaurora.org \
    --cc=hpa@zytor.com \
    --cc=linux-arm-msm-owner@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®