From: Thomas Gleixner <tglx@linutronix.de>
To: Darren Hart <dvhart@linux.intel.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@elte.hu>,
Eric Dumazet <eric.dumazet@gmail.com>,
John Kacur <jkacur@redhat.com>
Subject: Re: [PATCH V2] futex: fix compiler warnings in exit_robust_list
Date: Wed, 10 Nov 2010 13:20:39 +0100 (CET) [thread overview]
Message-ID: <alpine.LFD.2.00.1011101313280.2900@localhost6.localdomain6> (raw)
In-Reply-To: <1288897200-13008-1-git-send-email-dvhart@linux.intel.com>
On Thu, 4 Nov 2010, Darren Hart wrote:
> The following commit introduced a compiler warning:
>
> Commit 1dcc41bb037533839753df983d31778b30b67d93
> futex: Change 3rd arg of fetch_robust_entry() to unsigned int*
This makes not really sense. That commit changed "int *pi" to
"unsigned int *pi" which did not introduce the warning by any
means. It's gcc being stupid, in fact it should have warned before
that change already.
And your patch is incomplete as it forgot to fix the same problem in
futex_compat.c
/me fixes
next prev parent reply other threads:[~2010-11-10 12:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-27 21:54 [PATCH 0/3] futex: compiler warning and cleanups Darren Hart
2010-10-27 21:54 ` [PATCH 1/3] futex: fix compiler warnings in exit_robust_list Darren Hart
2010-11-04 10:49 ` [1/3] " Uwe Kleine-König
2010-11-04 19:00 ` [PATCH V2] " Darren Hart
2010-11-10 12:20 ` Thomas Gleixner [this message]
[not found] ` <tip-4c115e951d80aff126468adaec7a6c7854f61ab8@git.kernel.org>
2010-11-10 16:14 ` [tip:core/urgent] futex: Address " Darren Hart
2010-11-10 20:16 ` Uwe Kleine-König
2010-11-10 20:21 ` Darren Hart
2010-11-10 20:22 ` Darren Hart
2010-10-27 21:54 ` [PATCH 2/3] futex: replace fshared and clockrt with combined flags Darren Hart
2010-11-08 16:47 ` Thomas Gleixner
2010-11-08 21:10 ` [PATCH V2] " Darren Hart
2010-10-27 21:54 ` [PATCH 3/3] futex: add futex_q static initializer Darren Hart
2010-11-08 16:42 ` Thomas Gleixner
2010-11-08 18:12 ` Peter Zijlstra
2010-11-08 19:39 ` Thomas Gleixner
2010-11-08 21:12 ` [PATCH V2] " Darren Hart
2010-11-08 21:40 ` [PATCH V3] " Darren Hart
2010-11-08 21:48 ` Thomas Gleixner
2010-11-08 21:59 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1011101313280.2900@localhost6.localdomain6 \
--to=tglx@linutronix.de \
--cc=dvhart@linux.intel.com \
--cc=eric.dumazet@gmail.com \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®