From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754427Ab0LGWdP (ORCPT ); Tue, 7 Dec 2010 17:33:15 -0500 Received: from www.tglx.de ([62.245.132.106]:34562 "EHLO www.tglx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754215Ab0LGWdO (ORCPT ); Tue, 7 Dec 2010 17:33:14 -0500 Date: Tue, 7 Dec 2010 23:32:46 +0100 (CET) From: Thomas Gleixner To: Yinghai Lu cc: Feng Tang , "mingo@redhat.com" , "hpa@zytor.com" , "alan@linux.intel.com" , "linux-kernel@vger.kernel.org" , "Brown, Len" , "linux-tip-commits@vger.kernel.org" Subject: Re: [tip:x86/platform] x86: Unify current 3 similar ways of saving IRQ info In-Reply-To: <4CFE8045.2030101@kernel.org> Message-ID: References: <1291349518-3502-1-git-send-email-feng.tang@intel.com> <4CFD226C.60308@kernel.org> <20101207133204.4d913c5a@feng-i7> <4CFE8045.2030101@kernel.org> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 7 Dec 2010, Yinghai Lu wrote: > On 12/07/2010 07:56 AM, Thomas Gleixner wrote: > > > > Same here. No caller is interested in the detailed return value. > > > > ok, after look at code and git log, i knew the reasons for those > strange duplicated functions. > > Alexy changed > > /* MP IRQ source entries */ > -struct mpc_config_intsrc mp_irqs[MAX_IRQ_SOURCES]; > +struct mp_config_intsrc mp_irqs[MAX_IRQ_SOURCES]; > > to make it decouple that with mpstable definition. so mptable will > have mpc_intsrc, and acpi etc will use mp_config_intsrc > > and he planed to add more member to mp_config_intsrc .... never happened. > > then I added those functions with different parameters. > > one year later JSR changed all back to mpc_instr... > > so now have some duplicated functions.... > So yes, we should use simple versions in > arch/x86/kernel/acpi/boot.c. ( assume functions mrst.c are copied > from there) > > and should kill print_mp_irq_info or print_MP_intsrc_info... Nice archaelogical detective work ! :) So now I have Fengs patch plus Yinghais series which seem to go nicely together, but I have the feeling that there is some stuff unresolved. Yinghai, Feng: could you please work out the missing bits an pieces (if any) and provide me a delta patch on top of the existing patches? Thanks, tglx