mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Avi Kivity <avi@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	linux-kernel@vger.kernel.org, kvm <kvm@vger.kernel.org>,
	Tom Lyon <pugs@cisco.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [PATCH v3 2/4] genirq: Inform handler about line sharing state
Date: Tue, 14 Dec 2010 22:46:46 +0100 (CET)	[thread overview]
Message-ID: <alpine.LFD.2.00.1012142243540.12146@localhost6.localdomain6> (raw)
In-Reply-To: <a59c76552ebeaa128022ba9bcc7ea0753b312447.1292281184.git.jan.kiszka@web.de>

On Mon, 13 Dec 2010, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>  	chip_bus_lock(desc);
>  	retval = __setup_irq(irq, desc, action);
>  	chip_bus_sync_unlock(desc);
>  
> -	if (retval)
> +	if (retval) {
> +		if (desc->action && !desc->action->next)
> +			desc->irq_data.drv_status &= ~IRQS_SHARED;

This is redundant. IRQS_SHARED gets set in a code path where all
checks are done already.

To make that more obvious we can set it right before

   raw_spin_unlock_irqrestore(&desc->lock, flags);

conditionally on (shared).

That way we can also move the kfree out of the mutex locked section.

Thanks,

	tglx

  parent reply	other threads:[~2010-12-14 21:47 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-13 22:59 [PATCH v3 0/4] KVM & genirq: Enable adaptive IRQ sharing for passed-through devices Jan Kiszka
2010-12-13 22:59 ` [PATCH v3 1/4] genirq: Introduce driver-readable IRQ status word Jan Kiszka
2010-12-14 20:47   ` Thomas Gleixner
2010-12-14 23:10     ` Jan Kiszka
2010-12-13 22:59 ` [PATCH v3 2/4] genirq: Inform handler about line sharing state Jan Kiszka
2010-12-14 20:54   ` Thomas Gleixner
2010-12-14 23:00     ` Jan Kiszka
2010-12-15 13:04       ` Thomas Gleixner
2010-12-15 14:18         ` Jan Kiszka
2010-12-15 14:49           ` Thomas Gleixner
2010-12-15 15:41           ` Thomas Gleixner
2010-12-15 15:49             ` Jan Kiszka
2010-12-15 16:02               ` Thomas Gleixner
2010-12-14 21:46   ` Thomas Gleixner [this message]
2010-12-14 23:01     ` Jan Kiszka
2010-12-15  8:05       ` Thomas Gleixner
2010-12-15  9:37         ` Jan Kiszka
2010-12-15  9:48           ` Thomas Gleixner
2010-12-16 13:13   ` Thomas Gleixner
2010-12-16 20:26     ` Jan Kiszka
2010-12-16 21:28       ` change of email address: pugs@cisco.com -> pugs@ieee.org Tom Lyon
2010-12-17  8:18       ` [PATCH v3 2/4] genirq: Inform handler about line sharing state Jan Kiszka
2010-12-17 10:23         ` Thomas Gleixner
2010-12-17 10:31           ` Jan Kiszka
2010-12-17 10:41             ` Thomas Gleixner
2010-12-17 10:48               ` Jan Kiszka
2010-12-17 15:25                 ` Thomas Gleixner
2010-12-17 16:06                   ` Jan Kiszka
2010-12-17 16:32                     ` Thomas Gleixner
2010-12-18 18:11                       ` Michael S. Tsirkin
2010-12-13 22:59 ` [PATCH v3 3/4] genirq: Add support for IRQF_COND_ONESHOT Jan Kiszka
2010-12-13 22:59 ` [PATCH v3 4/4] KVM: Allow host IRQ sharing for passed-through PCI 2.3 devices Jan Kiszka
2010-12-14  8:53 ` [PATCH v3 0/4] KVM & genirq: Enable adaptive IRQ sharing for passed-through devices Avi Kivity
2010-12-14 22:01 ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.1012142243540.12146@localhost6.localdomain6 \
    --to=tglx@linutronix.de \
    --cc=alex.williamson@redhat.com \
    --cc=avi@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=jan.kiszka@web.de \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=pugs@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®