From: Thomas Gleixner <tglx@linutronix.de>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
andi@firstfloor.org, johnstul@us.ibm.com, williams@redhat.com,
schwidefsky@de.ibm.com, mingo@elte.hu,
linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/tsc] x86: Improve TSC calibration using a delayed workqueue
Date: Tue, 11 Jan 2011 11:26:11 +0100 (CET) [thread overview]
Message-ID: <alpine.LFD.2.00.1101111124590.12146@localhost6.localdomain6> (raw)
In-Reply-To: <20110111095640.GC22867@shutemov.name>
On Tue, 11 Jan 2011, Kirill A. Shutemov wrote:
> On Tue, Jan 11, 2011 at 09:37:15AM +0100, Thomas Gleixner wrote:
> > Does the patch below fix it ? We can end up with tsc_khz=0 there :(
>
> Yes, it does.
>
> Bisected-and-tested-by: Kirill A. Shutemov <kas@openvz.org>
Looking deeper, we should avoid to schedule the delayed init
completely. Does that work as well ?
Thanks,
tglx
---
diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
index 03d2ea8..823f79a 100644
--- a/arch/x86/kernel/tsc.c
+++ b/arch/x86/kernel/tsc.c
@@ -965,7 +965,7 @@ out:
static int __init init_tsc_clocksource(void)
{
- if (!cpu_has_tsc || tsc_disabled > 0)
+ if (!cpu_has_tsc || tsc_disabled > 0 || !tsc_khz)
return 0;
if (tsc_clocksource_reliable)
next prev parent reply other threads:[~2011-01-11 10:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-06 0:39 [PATCH] Greatly improve " John Stultz
2010-11-07 20:41 ` Andi Kleen
2010-11-08 22:04 ` john stultz
2010-11-09 13:43 ` Andi Kleen
2010-11-09 21:41 ` john stultz
2010-11-10 13:47 ` Andi Kleen
2010-12-05 11:18 ` [tip:x86/tsc] x86: Improve " tip-bot for John Stultz
2011-01-11 8:13 ` Kirill A. Shutemov
2011-01-11 8:26 ` Thomas Gleixner
2011-01-11 8:30 ` Kirill A. Shutemov
2011-01-11 8:37 ` Thomas Gleixner
2011-01-11 9:56 ` Kirill A. Shutemov
2011-01-11 10:26 ` Thomas Gleixner [this message]
2011-01-13 17:49 ` Konrad Rzeszutek Wilk
2011-01-13 18:01 ` john stultz
2011-01-13 21:40 ` [PATCH] acpi/pm: If failed at validating ACPI PM timer, inhibit future reads Konrad Rzeszutek Wilk
2011-01-13 22:15 ` Thomas Gleixner
2011-01-14 14:09 ` Konrad Rzeszutek Wilk
2011-01-14 15:44 ` john stultz
2011-01-14 15:54 ` john stultz
2011-01-14 16:02 ` Thomas Gleixner
2011-01-14 16:33 ` john stultz
2011-01-14 16:28 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1101111124590.12146@localhost6.localdomain6 \
--to=tglx@linutronix.de \
--cc=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=johnstul@us.ibm.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=schwidefsky@de.ibm.com \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®