From: James Simmons <jsimmons@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
Dave Airlie <airlied@linux.ie>,
DRI mailing list <dri-devel@lists.freedesktop.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [git pull] drm for rc1
Date: Wed, 12 Jan 2011 16:39:07 +0000 (GMT) [thread overview]
Message-ID: <alpine.LFD.2.00.1101121608560.8212@casper.infradead.org> (raw)
In-Reply-To: <AANLkTik32TC_eMbe0rZ+g11hFy9Z2_yY38avzY0GbgPv@mail.gmail.com>
> IOW, I'm inclined to just do the revert. The "fix" clearly breaks
> things, and now you're adding random parts of the function back rather
> than just calling the "fill_fix()" function like things used to. Why?
Its not the final patch. I'm trying to get feedback on what broke exactly.
> The commit message in dfe63bb0ad98 doesn't support any of these hacks
> - it just seems to say that drm_fb_helper_fill_fix() should also have
> been called from setcolreg().
>
> So why don't we just revert the commit and instead add that
> drm_fb_helper_fill_fix() to setcolreg()?
Fine by me. The real problem is the nouveau driver is using the
framebuffer device (fb_fillrect) before set_par is ever called.
Before calling set_par the framebuffer state is not defined.
next prev parent reply other threads:[~2011-01-12 16:39 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-10 22:59 Dave Airlie
2011-01-11 4:16 ` Linus Torvalds
2011-01-11 4:48 ` Dave Airlie
2011-01-11 4:51 ` Dave Airlie
2011-01-11 10:58 ` Chris Wilson
2011-01-11 6:06 ` Jesse Barnes
2011-01-11 6:28 ` Dave Airlie
2011-01-11 7:04 ` Dave Airlie
2011-01-11 10:35 ` Anca Emanuel
2011-01-11 13:33 ` Pavel Machek
2011-01-11 14:14 ` Chris Wilson
2011-02-23 18:53 ` Pavel Machek
2011-01-11 16:01 ` Linus Torvalds
2011-01-11 16:11 ` Anca Emanuel
2011-01-11 16:25 ` Anca Emanuel
2011-01-11 17:58 ` Anca Emanuel
2011-01-11 19:00 ` Linus Torvalds
2011-01-11 19:12 ` Jesse Barnes
2011-01-11 19:25 ` Linus Torvalds
2011-01-11 19:45 ` Jesse Barnes
2011-01-11 19:53 ` Linus Torvalds
2011-01-11 20:05 ` Chris Wilson
2011-01-11 22:16 ` Linus Torvalds
2011-01-11 22:31 ` Chris Wilson
2011-01-11 23:01 ` Linus Torvalds
2011-01-12 1:36 ` Linus Torvalds
2011-01-12 1:54 ` Dave Airlie
2011-01-11 23:20 ` Christian Borntraeger
2011-01-11 23:28 ` Linus Torvalds
2011-01-12 11:21 ` Christian Borntraeger
2011-01-12 12:49 ` James Simmons
2011-01-12 13:03 ` Christian Borntraeger
2011-01-12 13:32 ` James Simmons
2011-01-12 13:45 ` Christian Borntraeger
2011-01-12 15:55 ` Linus Torvalds
2011-01-12 16:39 ` James Simmons [this message]
2011-01-12 13:36 ` Anca Emanuel
2011-01-12 13:45 ` James Simmons
2011-01-12 13:55 ` Anca Emanuel
2011-01-12 14:35 ` Christian Borntraeger
2011-01-12 16:53 ` James Simmons
2011-01-12 15:13 ` Anca Emanuel
2011-01-12 15:25 ` Anca Emanuel
2011-01-12 15:40 ` James Simmons
2011-01-12 15:55 ` Anca Emanuel
2011-01-13 17:55 ` James Simmons
2011-01-13 19:53 ` Anca Emanuel
2011-01-14 16:29 ` Anca Emanuel
2011-01-14 16:38 ` James Simmons
2011-01-14 18:22 ` Anca Emanuel
2011-01-14 18:26 ` James Simmons
2011-01-14 18:40 ` Anca Emanuel
2011-01-14 19:02 ` Anca Emanuel
2011-02-19 15:14 ` Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1101121608560.8212@casper.infradead.org \
--to=jsimmons@infradead.org \
--cc=airlied@linux.ie \
--cc=borntraeger@de.ibm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®