From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753518Ab1AUK2s (ORCPT <rfc822;w@1wt.eu>);
	Fri, 21 Jan 2011 05:28:48 -0500
Received: from www.tglx.de ([62.245.132.106]:33895 "EHLO www.tglx.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750710Ab1AUK2q (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 21 Jan 2011 05:28:46 -0500
Date: Fri, 21 Jan 2011 11:27:59 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Sam Ravnborg <sam@ravnborg.org>
cc: Chris Metcalf <cmetcalf@tilera.com>, LKML <linux-kernel@vger.kernel.org>,
        Linux-Arch <linux-arch@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [patch 36/37] tile: Use generic irq Kconfig
In-Reply-To: <20110120190818.GA22638@merkur.ravnborg.org>
Message-ID: <alpine.LFD.2.00.1101211127260.2971@localhost6.localdomain6>
References: <20110119205258.462759212@linutronix.de> <20110119210840.631350392@linutronix.de> <4D3884E3.8050009@tilera.com> <20110120190818.GA22638@merkur.ravnborg.org>
User-Agent: Alpine 2.00 (LFD 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 20 Jan 2011, Sam Ravnborg wrote:

> On Thu, Jan 20, 2011 at 01:54:27PM -0500, Chris Metcalf wrote:
> > On 1/19/2011 4:50 PM, Thomas Gleixner wrote:
> > > No functional change.
> > >
> > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> > > Cc: Chris Metcalf <cmetcalf@tilera.com>
> > > ---
> > >  arch/tile/Kconfig |   16 ++++++----------
> > >  1 file changed, 6 insertions(+), 10 deletions(-)
> > >
> > > Index: linux-2.6/arch/tile/Kconfig
> > > ===================================================================
> > > --- linux-2.6.orig/arch/tile/Kconfig
> > > +++ linux-2.6/arch/tile/Kconfig
> > > @@ -1,22 +1,18 @@
> > >  # For a description of the syntax of this configuration file,
> > >  # see Documentation/kbuild/config-language.txt.
> > >  
> > > +config TILE
> > > +       def_bool y
> > > +       select HAVE_GENERIC_HARDIRQS
> > > +       select GENERIC_IRQ_PROBE
> > > +       select GENERIC_PENDING_IRQ if SMP
> > > +
> > >  [...]
> > 
> > I'm not sure it's legal to have two "config TILE" blocks in this Kconfig
> > file; there's already one further down.

Missed that.
 
> It is OK to have two "config TILE" blocks.
> You should take care of moving the other one up after this goes in.

Will consolidate before sending it upstream.

Thanks,

	tglx