From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754316Ab1AUW3i (ORCPT ); Fri, 21 Jan 2011 17:29:38 -0500 Received: from mail-vw0-f46.google.com ([209.85.212.46]:51166 "EHLO mail-vw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753323Ab1AUW3g (ORCPT ); Fri, 21 Jan 2011 17:29:36 -0500 Date: Fri, 21 Jan 2011 17:29:33 -0500 (EST) From: Nicolas Pitre X-X-Sender: nico@xanadu.home To: Russell King - ARM Linux cc: Dima Zavin , Saravana Kannan , Lorenzo Pieralisi , linux-sh@vger.kernel.org, Ben Herrenschmidt , Sascha Hauer , lkml , Paul Mundt , Ben Dooks , Uwe Kleine-K??nig , Vincent Guittot , Jeremy Kerr , linux-arm-kernel@lists.infradead.org Subject: Re: Locking in the clk API In-Reply-To: <20110121220238.GE23151@n2100.arm.linux.org.uk> Message-ID: References: <201101111016.42819.jeremy.kerr@canonical.com> <20110111031552.GJ3760@linux-sh.org> <4D3862DB.5000708@fluff.org> <20110120185617.GI6335@n2100.arm.linux.org.uk> <4D3907BD.4040900@codeaurora.org> <20110121220238.GE23151@n2100.arm.linux.org.uk> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 21 Jan 2011, Russell King - ARM Linux wrote: > On Fri, Jan 21, 2011 at 04:53:44PM -0500, Nicolas Pitre wrote: > > So I think that the API must be augmented with more methods, such as: > > > > clk_slow_enable(): > > - may sleep > > - may be a no-op if the clk_fast_enable() is supported > > > > clk_fast_enable(): > > - may not sleep, used in atomic context > > - may be a no-op if controlling the clock takes time, in which case > > clk_slow_enable() must have set the clock up entirely > > > > ... and similar for clk_slow_disable() and clk_fast_disable(). > > Isn't this along the same lines as my clk_prepare() vs clk_enable() > suggestion? > > I suggested that clk_prepare() be callable only from non-atomic contexts, > and do whatever's required to ensure that the clock is available. That > may end up enabling the clock as a result. > > clk_enable() callable from atomic contexts, and turns the clock on if > the hardware supports such an operation. > > So, if you have something like: > > Xtal--->PLL--->Routing/Masking--->Device > > clk = clk_get() returns the clock for the device. > > clk_prepare(clk) would walk up the clock tree, selecting the routing and > preparing each clock. Clocks prior to _and_ including the PLL would need > to be enabled. > > clk_enable(clk) would walk up the tree if the clock isn't already enabled, > calling clk_enable() on the parent clock. As we require prepared clocks > to already be enabled, this automatically stops at the PLL. > > To encourage correct usage, we just need to make sure that clk_prepare() > has a might_sleep() thing, and clk_enable() throws a fit if it's used > on a clk without prepare being used first. The second point is not easy > to do in a foolproof manner though, but doing _something_ is better than > nothing. Exactly. That model does cover both situations: i.e. clocks with slow setups which need to sleep, and clocks with fast setups that can be dealt with and taken advantage of within atomic context. And in some cases there is even a mixture of both involved. Nicolas