From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752902Ab1AVMnJ (ORCPT ); Sat, 22 Jan 2011 07:43:09 -0500 Received: from www.tglx.de ([62.245.132.106]:55648 "EHLO www.tglx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752129Ab1AVMnH (ORCPT ); Sat, 22 Jan 2011 07:43:07 -0500 Date: Sat, 22 Jan 2011 13:42:39 +0100 (CET) From: Thomas Gleixner To: Richard Cochran cc: linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, netdev@vger.kernel.org, Alan Cox , Arnd Bergmann , Christoph Lameter , David Miller , John Stultz , Krzysztof Halasa , Peter Zijlstra , Rodolfo Giometti Subject: Re: [PATCH V9 08/13] posix clocks: cleanup the CLOCK_DISPTACH macro In-Reply-To: <20110122123840.GA30830@riccoc20.at.omicron.at> Message-ID: References: <90b2beef441615d01c93fcad029c44af4e505c5f.1294917348.git.richard.cochran@omicron.at> <20110122123840.GA30830@riccoc20.at.omicron.at> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 22 Jan 2011, Richard Cochran wrote: > On Thu, Jan 13, 2011 at 06:03:24PM +0100, Thomas Gleixner wrote: > > On Thu, 13 Jan 2011, Richard Cochran wrote: > > > int posix_cpu_clock_getres(const clockid_t which_clock, struct timespec *ts); > > > int posix_cpu_clock_get(const clockid_t which_clock, struct timespec *ts); > > > -int posix_cpu_clock_set(const clockid_t which_clock, const struct timespec *ts); > > > +int posix_cpu_clock_set(const clockid_t which_clock, struct timespec *ts); > > > > Shouldn't we change the clock_set function to have *ts const in all places ? > > The common_clock_set function calls: > > do_sys_settimeofday > security_settime > cap_settime > do_settimeofday > > so all their signatures must also change. > > Should I add that into my patch set? Yes please as a separate patch. Thanks, tglx