From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751578Ab1A0PNf (ORCPT <rfc822;w@1wt.eu>);
	Thu, 27 Jan 2011 10:13:35 -0500
Received: from www.tglx.de ([62.245.132.106]:34501 "EHLO www.tglx.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751012Ab1A0PNf (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 27 Jan 2011 10:13:35 -0500
Date: Thu, 27 Jan 2011 16:12:40 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: David Howells <dhowells@redhat.com>
cc: LKML <linux-kernel@vger.kernel.org>, Peter Zijlstra <peterz@infradead.org>,
        x86@kernel.org, Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Richard Henderson <rth@twiddle.net>, Tony Luck <tony.luck@intel.com>,
        Heiko Carstens <heiko.carstens@de.ibm.com>,
        Paul Mundt <lethal@linux-sh.org>, David Miller <davem@davemloft.net>,
        Chris Zankel <chris@zankel.net>
Subject: Re: rwsem: rwsem: Remove redundant asmregparm annotation
In-Reply-To: <19896.1296140620@redhat.com>
Message-ID: <alpine.LFD.2.00.1101271612050.31804@localhost6.localdomain6>
References: <alpine.LFD.2.00.1101262130450.31804@localhost6.localdomain6> <20110126195810.247325792@linutronix.de> <20110126195833.970840140@linutronix.de> <19896.1296140620@redhat.com>
User-Agent: Alpine 2.00 (LFD 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 27 Jan 2011, David Howells wrote:

> Thomas Gleixner <tglx@linutronix.de> wrote:
> 
> > Peter Zijlstra pointed out, that the only user of asmregparm (x86) is
> > compiling the kernel already with -mregparm=3. So the annotation of
> > the rwsem functions is redundant. Remove it.
> 
> That's fine - as long as we never remove the -mregparm=3 on i386.  The inline
> assembly relies on the regparm=3 calling convention.

If we remove that we'll break more than rwsems :)

Thanks,

	tglx