From: Thomas Gleixner <tglx@linutronix.de>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: Paul Menage <menage@google.com>, Li Zefan <lizf@cn.fujitsu.com>,
containers@lists.linux-foundation.org,
jacob.jun.pan@linux.intel.com,
Arjan van de Ven <arjan@linux.intel.com>,
linux-kernel@vger.kernel.org, Matt Helsley <matthltc@us.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-api@vger.kernel.org
Subject: Re: [PATCH, v6 3/3] cgroups: introduce timer slack controller
Date: Tue, 15 Feb 2011 07:04:00 +0100 (CET) [thread overview]
Message-ID: <alpine.LFD.2.00.1102150658540.26192@localhost6.localdomain6> (raw)
In-Reply-To: <20110214223939.GA6230@shutemov.name>
On Tue, 15 Feb 2011, Kirill A. Shutemov wrote:
> On Mon, Feb 14, 2011 at 06:01:06PM +0100, Thomas Gleixner wrote:
> > > I think silent change here is wrong. cpuset returns -EBUSY in similar
> > > case.
> >
> > And how is cpuset relevant for this ? Not at all. This is about
> > timer_slack and we better have a well defined scheme for all of this
> > and not some cobbled together thing with tons of exceptions and corner
> > cases. Of course undocumented as far the code goes.
>
> I don't like silent cascade changes. Userspace can implement it if
> needed. -EBUSY is appropriate.
And I don't like totally uncommented code which follows come cobbled
together completely non obvious rules.
It's not about what you like. It's about getting useful functionality
when we add a new infrastructure like this.
So could you please explain what the rules of updating are, so that a
reviewer has a chance to understand the rationale of all this.
Thanks,
tglx
next prev parent reply other threads:[~2011-02-15 6:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-14 13:06 [PATCH, v6 0/3] Introduce " Kirill A. Shutsemov
2011-02-14 13:06 ` [PATCH, v6 1/3] cgroups: export cgroup_iter_{start,next,end} Kirill A. Shutsemov
2011-02-14 13:27 ` Thomas Gleixner
2011-02-14 14:39 ` Kirill A. Shutemov
2011-02-14 15:09 ` Thomas Gleixner
2011-02-14 13:06 ` [PATCH, v6 2/3] Implement timer slack notifier chain Kirill A. Shutsemov
2011-02-14 13:32 ` Thomas Gleixner
2011-02-14 14:52 ` Kirill A. Shutemov
2011-02-14 15:16 ` Thomas Gleixner
2011-02-14 13:06 ` [PATCH, v6 3/3] cgroups: introduce timer slack controller Kirill A. Shutsemov
2011-02-14 13:59 ` Matt Helsley
2011-02-14 22:59 ` Kirill A. Shutemov
2011-02-15 0:00 ` Matt Helsley
2011-02-15 0:10 ` Kirill A. Shutemov
2011-02-14 14:00 ` Thomas Gleixner
2011-02-14 15:19 ` Kirill A. Shutemov
2011-02-14 17:01 ` Thomas Gleixner
2011-02-14 22:39 ` Kirill A. Shutemov
2011-02-14 23:39 ` Matt Helsley
2011-02-15 6:04 ` Thomas Gleixner [this message]
2011-02-14 13:26 ` [PATCH, v6 0/3] Introduce " Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1102150658540.26192@localhost6.localdomain6 \
--to=tglx@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=containers@lists.linux-foundation.org \
--cc=jacob.jun.pan@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=matthltc@us.ibm.com \
--cc=menage@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®